Web Animations: Timeline should not advance during task execution

Source/core/animation/AnimationClock.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef AnimationClock_h
 #define AnimationClock_h
 
-#include "wtf/CurrentTime.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace WebCore {
 
-// FIXME: This value is used to suppress updates when time is required outside of a frame.
-// The purpose of allowing the clock to update during such periods is to allow animations
-// to have an appropriate start time and for getComputedStyle to attempt to catch-up to a
-// compositor animation. However a more accurate system might be to attempt to phase-lock
-// with the frame clock.
-const double minTimeBeforeUnsynchronizedAnimationClockTick = 0.005;
-
 class AnimationClock {
 public:
-    static PassOwnPtr<AnimationClock> create(WTF::TimeFunction monotonicallyIncreasingTime = WTF::monotonicallyIncreasingTime)
+    AnimationClock()
+        : m_time(0)
     {
-        return adoptPtr(new AnimationClock(monotonicallyIncreasingTime));
     }
 
     void updateTime(double time);
     double currentTime();
-    void unfreeze() { m_frozen = false; }
-    void resetTimeForTesting() { m_time = 0; m_frozen = true; }
+    void resetTimeForTesting() { m_time = 0; taskTime() = 0; }
+
+    static double& taskTime()

[shans, 2014/04/30 20:43:07]

I think this needs a comment indicating its purpose

[esprehn, 2014/04/30 22:43:50]

Can we use a regular getter/setter pair instead of returning the number by
reference?

[dstockwell, 2014/04/30 22:59:51]

It's a static local, I can't access it from two different methods. It doesn't
need to be local if there's a good place to initialize it once. Is there?

[esprehn, 2014/04/30 23:54:33]

Don't use a static local, make it a static member of the AnimationClock and
initialize it in the cpp file. Then put the getter and setter here.

+    {
+        static double time = 0;
+        return time;
+    }
+
+    static void notifyTaskStartTime(double time) { taskTime() = time; }
 
 private:
-    AnimationClock(WTF::TimeFunction monotonicallyIncreasingTime)
-        : m_monotonicallyIncreasingTime(monotonicallyIncreasingTime)
-        , m_time(0)
-        , m_frozen(false)
-    {
-    }
-    WTF::TimeFunction m_monotonicallyIncreasingTime;
     double m_time;
-    bool m_frozen;
 };
 
 } // namespace WebCore
 
 #endif // AnimationClock_h