Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: Source/core/animation/AnimationClock.h

Issue 251183006: Web Animations: Timeline should not advance during task execution (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Deflake element-animate-position-crash. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef AnimationClock_h 31 #ifndef AnimationClock_h
32 #define AnimationClock_h 32 #define AnimationClock_h
33 33
34 #include "wtf/CurrentTime.h" 34 #include "wtf/CurrentTime.h"
35 #include "wtf/PassOwnPtr.h" 35 #include "wtf/PassOwnPtr.h"
36 #include "wtf/Noncopyable.h"
36 37
37 namespace WebCore { 38 namespace WebCore {
38 39
39 // FIXME: This value is used to suppress updates when time is required outside o f a frame.
40 // The purpose of allowing the clock to update during such periods is to allow a nimations
41 // to have an appropriate start time and for getComputedStyle to attempt to catc h-up to a
42 // compositor animation. However a more accurate system might be to attempt to p hase-lock
43 // with the frame clock.
44 const double minTimeBeforeUnsynchronizedAnimationClockTick = 0.005;
45
46 class AnimationClock { 40 class AnimationClock {
41 WTF_MAKE_NONCOPYABLE(AnimationClock);
47 public: 42 public:
48 static PassOwnPtr<AnimationClock> create(WTF::TimeFunction monotonicallyIncr easingTime = WTF::monotonicallyIncreasingTime) 43 explicit AnimationClock(WTF::TimeFunction monotonicallyIncreasingTime = WTF: :monotonicallyIncreasingTime)
44 : m_monotonicallyIncreasingTime(monotonicallyIncreasingTime)
45 , m_time(0)
46 , m_currentTask(0)
49 { 47 {
50 return adoptPtr(new AnimationClock(monotonicallyIncreasingTime));
51 } 48 }
52 49
53 void updateTime(double time); 50 void updateTime(double time);
54 double currentTime(); 51 double currentTime();
55 void unfreeze() { m_frozen = false; } 52 void resetTimeForTesting();
56 void resetTimeForTesting() { m_time = 0; m_frozen = true; } 53
54 static void notifyTaskStart() { ++s_currentTask; }
57 55
58 private: 56 private:
59 AnimationClock(WTF::TimeFunction monotonicallyIncreasingTime)
60 : m_monotonicallyIncreasingTime(monotonicallyIncreasingTime)
61 , m_time(0)
62 , m_frozen(false)
63 {
64 }
65 WTF::TimeFunction m_monotonicallyIncreasingTime; 57 WTF::TimeFunction m_monotonicallyIncreasingTime;
66 double m_time; 58 double m_time;
67 bool m_frozen; 59 unsigned m_currentTask;
60 static unsigned s_currentTask;
68 }; 61 };
69 62
70 } // namespace WebCore 63 } // namespace WebCore
71 64
72 #endif // AnimationClock_h 65 #endif // AnimationClock_h
OLDNEW
« no previous file with comments | « LayoutTests/web-animations-api/timeline-time.html ('k') | Source/core/animation/AnimationClock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698