Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 251183002: Deprecate NodeIterator.expandEntityReferences / TreeWalker.expandEntityReferences (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, chrishtr, arv+blink, sof, eae+blinkwatch, ojan, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Deprecate NodeIterator.expandEntityReferences / TreeWalker.expandEntityReferences Deprecate NodeIterator.expandEntityReferences / TreeWalker.expandEntityReferences as those were removed from the DOM specification: http://dom.spec.whatwg.org/#dom-traversal Those properties were never implemented in Chromium and always return false. We already dropped the corresponding argument to createNodeIterator() / createTreeWalker(). Firefox has already removed them since version 21: https://developer.mozilla.org/en-US/docs/Web/API/NodeIterator.expandEntityReferences https://developer.mozilla.org/en-US/docs/Web/API/TreeWalker.expandEntityReferences However, since these properties were standard and are still present in IE11, I propose to deprecate them and measure their usage to make sure it is safe to eventually remove. R=arv@chromium.org, tkent@chromium.org BUG=367866 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172913

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M LayoutTests/fast/dom/NodeIterator/NodeIterator-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/NodeIterator.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeWalker.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 7 months ago (2014-04-28 18:41:17 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 7 months ago (2014-04-28 18:45:45 UTC) #2
Inactive
Could an API OWNER please review?
6 years, 7 months ago (2014-04-29 13:12:55 UTC) #3
eseidel
lgtm https://www.youtube.com/watch?v=-dJolYw8tnk
6 years, 7 months ago (2014-04-29 17:00:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/251183002/1
6 years, 7 months ago (2014-04-29 17:00:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 17:00:40 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-29 17:00:40 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 7 months ago (2014-04-29 17:05:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/251183002/20001
6 years, 7 months ago (2014-04-29 17:06:00 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 04:13:47 UTC) #10
Message was sent while issue was closed.
Change committed as 172913

Powered by Google App Engine
This is Rietveld 408576698