Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2511823002: Fix PropertyConverter test leak. (Closed)

Created:
4 years, 1 month ago by msw
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PropertyConverter test leak. Mark test props as window-owned. BUG=666373 TEST=automated R=sky@chromium.org Committed: https://crrev.com/8235f068aa3a3396085d425908f57789ebcbc910 Cr-Commit-Position: refs/heads/master@{#432996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/aura/mus/property_converter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 1 month ago (2016-11-17 18:51:32 UTC) #5
sky
LGTM
4 years, 1 month ago (2016-11-17 20:07:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511823002/1
4 years, 1 month ago (2016-11-17 21:36:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 22:31:02 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8235f068aa3a3396085d425908f57789ebcbc910
Cr-Commit-Position: refs/heads/master@{#432996}

Powered by Google App Engine
This is Rietveld 408576698