Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: runtime/vm/assembler_x64_test.cc

Issue 25118002: Eliminates more large immediates from x64 code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64_test.cc
===================================================================
--- runtime/vm/assembler_x64_test.cc (revision 28057)
+++ runtime/vm/assembler_x64_test.cc (working copy)
@@ -1292,14 +1292,14 @@
ExternalLabel call2("LeafReturnArgument",
reinterpret_cast<uword>(LeafReturnArgument));
int space = ComputeStackSpaceReservation(0, 8);
- __ AddImmediate(RSP, Immediate(-space));
+ __ subq(RSP, Immediate(space));
__ call(&call1);
- __ AddImmediate(RSP, Immediate(space));
+ __ addq(RSP, Immediate(space));
space = ComputeStackSpaceReservation(0, 8);
- __ AddImmediate(RSP, Immediate(-space));
+ __ subq(RSP, Immediate(space));
__ movl(RDI, RAX);
__ call(&call2);
- __ AddImmediate(RSP, Immediate(space));
+ __ addq(RSP, Immediate(space));
__ ret();
}
@@ -1314,9 +1314,9 @@
ExternalLabel call1("LeafReturn42", reinterpret_cast<uword>(LeafReturn42));
Label L;
int space = ComputeStackSpaceReservation(0, 8);
- __ AddImmediate(RSP, Immediate(-space));
+ __ subq(RSP, Immediate(space));
__ call(&L);
- __ AddImmediate(RSP, Immediate(space));
+ __ addq(RSP, Immediate(space));
__ ret();
__ Bind(&L);
__ jmp(&call1);
@@ -2183,24 +2183,24 @@
Label fail;
__ EnterDartFrame(0);
__ LoadObject(RAX, obj, PP);
- __ CompareObject(RAX, obj);
+ __ CompareObject(RAX, obj, PP);
__ j(NOT_EQUAL, &fail);
__ LoadObject(RCX, obj, PP);
- __ CompareObject(RCX, obj);
+ __ CompareObject(RCX, obj, PP);
__ j(NOT_EQUAL, &fail);
const Smi& smi = Smi::ZoneHandle(Smi::New(15));
__ LoadObject(RCX, smi, PP);
- __ CompareObject(RCX, smi);
+ __ CompareObject(RCX, smi, PP);
__ j(NOT_EQUAL, &fail);
__ pushq(RAX);
- __ StoreObject(Address(RSP, 0), obj);
+ __ StoreObject(Address(RSP, 0), obj, PP);
__ popq(RCX);
- __ CompareObject(RCX, obj);
+ __ CompareObject(RCX, obj, PP);
__ j(NOT_EQUAL, &fail);
__ pushq(RAX);
- __ StoreObject(Address(RSP, 0), smi);
+ __ StoreObject(Address(RSP, 0), smi, PP);
__ popq(RCX);
- __ CompareObject(RCX, smi);
+ __ CompareObject(RCX, smi, PP);
__ j(NOT_EQUAL, &fail);
__ movl(RAX, Immediate(1)); // OK
__ LeaveFrameWithPP();
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698