Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: blimp/net/tcp_engine_transport.h

Issue 2511773003: Fix potential teardown race conditions with TCPEngineTransport's PostTasks. (Closed)
Patch Set: git cl format Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/net/tcp_engine_transport.cc » ('j') | blimp/net/tcp_engine_transport.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/tcp_engine_transport.h
diff --git a/blimp/net/tcp_engine_transport.h b/blimp/net/tcp_engine_transport.h
index b7e85e06b83ec98e60d4439e80dd710370d0c846..f5ec87b53090ccf42a3bcf8e5d5b883cad8efcdd 100644
--- a/blimp/net/tcp_engine_transport.h
+++ b/blimp/net/tcp_engine_transport.h
@@ -42,13 +42,13 @@ class BLIMP_NET_EXPORT TCPEngineTransport : public BlimpEngineTransport {
std::unique_ptr<MessagePort> TakeMessagePort();
private:
- void OnTCPConnectAccepted(int result);
+ void OnTCPConnectAccepted(net::CompletionCallback callback, int result);
const net::IPEndPoint address_;
net::NetLog* net_log_;
std::unique_ptr<net::ServerSocket> server_socket_;
std::unique_ptr<net::StreamSocket> accepted_socket_;
- net::CompletionCallback connect_callback_;
+ base::WeakPtrFactory<TCPEngineTransport> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(TCPEngineTransport);
};
« no previous file with comments | « no previous file | blimp/net/tcp_engine_transport.cc » ('j') | blimp/net/tcp_engine_transport.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698