Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 2511753002: Fix crash while inferencing instance field type. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix crash while inferencing instance field type. The type does not look correct, should it be '(dynamic) → dynamic'? But at least it does not crash anymore. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/225b062be8905d51de5de83598fb3bd67c7dd598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 3 chunks +18 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-17 15:22:27 UTC) #1
Paul Berry
lgtm
4 years, 1 month ago (2016-11-17 16:53:19 UTC) #2
scheglov
4 years, 1 month ago (2016-11-17 18:24:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
225b062be8905d51de5de83598fb3bd67c7dd598 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698