Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2511733005: Update shared library extension on AIX to .a. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
Reviewers:
sxa, scottmg
CC:
gyp-developer_googlegroups.com
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Patch Set 1 : initial patch from https://crrev.com/2492233002#ps1 #

Patch Set 2 : revert copyright change, update AUTHORS, fix presubmit checks #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M AUTHORS View 1 1 chunk +4 lines, -3 lines 0 comments Download
M PRESUBMIT.py View 1 2 chunks +14 lines, -12 lines 1 comment Download
M pylib/gyp/generator/make.py View 1 2 chunks +8 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
4 years, 1 month ago (2016-11-17 21:09:17 UTC) #1
Dirk Pranke
https://codereview.chromium.org/2511733005/diff/20001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/2511733005/diff/20001/PRESUBMIT.py#newcode96 PRESUBMIT.py:96: input_api, output_api, license_header=_LicenseHeader(input_api))) Apparently we were looking for difference ...
4 years, 1 month ago (2016-11-17 21:14:22 UTC) #2
scottmg
lgtm https://codereview.chromium.org/2511733005/diff/20001/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/2511733005/diff/20001/pylib/gyp/generator/make.py#newcode96 pylib/gyp/generator/make.py:96: default_variables.setdefault('SHARED_LIB_SUFFIX', '.a') crazy!
4 years, 1 month ago (2016-11-17 21:21:10 UTC) #3
Dirk Pranke
Committed patchset #2 (id:20001) manually as 940a15ee3f1c89f193cb4c19373b3f6e9ad15b95.
4 years, 1 month ago (2016-11-17 23:28:45 UTC) #5
sxa
4 years, 1 month ago (2016-11-18 11:45:00 UTC) #6
Message was sent while issue was closed.
On 2016/11/17 23:28:45, Dirk Pranke wrote:
> Committed patchset #2 (id:20001) manually as
> 940a15ee3f1c89f193cb4c19373b3f6e9ad15b95.

Thanks Dirk :-)

Powered by Google App Engine
This is Rietveld 408576698