[Android] Make the test runner terminate gracefully on SIGTERM.

[Android] Make the test runner terminate gracefully on SIGTERM.

This includes writing out the JSON results file, even if we have
no results.

BUG=664308
Committed: https://crrev.com/b346038701a73dbc4c1758fe9baf7b23614fbe60
Cr-Commit-Position: refs/heads/master@{#433234}

[jbudorick, 2016-11-17 17:01:02]

jbudorick@chromium.org changed reviewers:
+ katthomas@google.com, mikecase@chromium.org

[jbudorick, 2016-11-17 17:01:03]

Requires https://codereview.chromium.org/2505383002/

[jbudorick, 2016-11-17 17:31:28]

jbudorick@chromium.org changed reviewers:
+ rnephew@chromium.org
- mikecase@chromium.org

[rnephew (Reviews Here), 2016-11-17 19:14:25]

lgtm

https://codereview.chromium.org/2511733004/diff/1/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/2511733004/diff/1/build/android/test_runner.p...
build/android/test_runner.py:746: test =
test_instance_factory.CreateTestInstance(args, infra_error)
Maybe test_instance instead of just test, since the others are named after the
thing in <thing>_factory.

No strong feelings on it, just a thought.

[jbudorick, 2016-11-18 16:17:56]

https://codereview.chromium.org/2511733004/diff/1/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/2511733004/diff/1/build/android/test_runner.p...
build/android/test_runner.py:746: test =
test_instance_factory.CreateTestInstance(args, infra_error)
On 2016/11/17 19:14:24, rnephew (Reviews Here) wrote:
> Maybe test_instance instead of just test, since the others are named after the
> thing in <thing>_factory.
> 
> No strong feelings on it, just a thought.

Done.

[jbudorick, 2016-11-18 16:17:59]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-11-18 16:17:59]

The patchset sent to the CQ was uploaded after l-g-t-m from rnephew@chromium.org
Link to the patchset: https://codereview.chromium.org/2511733004/#ps20001
(title: "rnephew comment")

[commit-bot: I haz the power, 2016-11-18 16:18:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 17:45:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 17:49:31]

Description was changed from

==========
[Android] Make the test runner terminate gracefully on SIGTERM.

This includes writing out the JSON results file, even if we have
no results.

BUG=664308
==========

to

==========
[Android] Make the test runner terminate gracefully on SIGTERM.

This includes writing out the JSON results file, even if we have
no results.

BUG=664308

Committed: https://crrev.com/b346038701a73dbc4c1758fe9baf7b23614fbe60
Cr-Commit-Position: refs/heads/master@{#433234}
==========

[commit-bot: I haz the power, 2016-11-18 17:49:32]

Patchset 2 (id:??) landed as
https://crrev.com/b346038701a73dbc4c1758fe9baf7b23614fbe60
Cr-Commit-Position: refs/heads/master@{#433234}

[Fady Samuel, 2016-11-18 18:14:10]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2511243005/ by fsamuel@chromium.org.

The reason for reverting is: Caused Android Builder to fail:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/Android%20Bui...
.