[debugger] handle stack overflow. Fail silently.

src/d8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <errno.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
 
 #include <algorithm>
@@ skipping 1788 matching lines @@
         v8::String::NewFromUtf8(isolate_, "receive", v8::NewStringType::kNormal)
             .ToLocalChecked();
     Local<Context> context = context_.Get(isolate_);
     Local<Value> callback =
         context->Global()->Get(context, callback_name).ToLocalChecked();
     if (callback->IsFunction()) {
       v8::TryCatch try_catch(isolate_);
       Local<Value> args[] = {message};
       MaybeLocal<Value> result = Local<Function>::Cast(callback)->Call(
           context, Undefined(isolate_), 1, args);
-      CHECK(!result.IsEmpty());  // Listeners may not throw.

[jgruber, 2016/11/17 13:56:55]

If this is removed, maybe we should remove similar checks for C++ listeners to
stay consistent.

Is there any way to get the best of both worlds, i.e. not crashing on stack
overflows within the listener but still handling exceptions within listeners? We
don't necessarily need to disallow them, as long as they're not silently
swallowed.

     }
   }
 
   Isolate* isolate_;
   Global<Context> context_;
 };
 
 class InspectorClient : public v8_inspector::V8InspectorClient {
  public:
   InspectorClient(Local<Context> context, bool connect) {
@@ skipping 1129 matching lines @@
 }
 
 }  // namespace v8
 
 
 #ifndef GOOGLE3
 int main(int argc, char* argv[]) {
   return v8::Shell::Main(argc, argv);
 }
 #endif