Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251173003: Don't fire idle active event when listener re-added (Closed)

Created:
6 years, 7 months ago by not at google - send to devlin
Modified:
6 years, 7 months ago
Reviewers:
Michael Courage
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Don't fire the chrome.idle.onStateChanged event when a listener is re-added after the idle state has changed. BUG=366580 R=courage@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267043

Patch Set 1 #

Patch Set 2 : compile #

Patch Set 3 : test #

Patch Set 4 : self nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M chrome/browser/extensions/api/idle/idle_api_unittest.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.cc View 1 2 3 2 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
not at google - send to devlin
6 years, 7 months ago (2014-04-28 22:13:24 UTC) #1
Michael Courage
lgtm
6 years, 7 months ago (2014-04-29 00:23:54 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 13:22:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/251173003/60001
6 years, 7 months ago (2014-04-29 13:22:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 14:15:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 14:15:49 UTC) #6
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 14:28:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/251173003/60001
6 years, 7 months ago (2014-04-29 14:30:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 15:40:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 15:40:01 UTC) #10
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 15:45:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/251173003/60001
6 years, 7 months ago (2014-04-29 15:46:53 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 15:48:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium
6 years, 7 months ago (2014-04-29 15:48:56 UTC) #14
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 16:00:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/251173003/60001
6 years, 7 months ago (2014-04-29 16:01:21 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:01:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:01:11 UTC) #18
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 22:03:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/251173003/60001
6 years, 7 months ago (2014-04-29 22:08:08 UTC) #20
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 02:14:24 UTC) #21
Message was sent while issue was closed. 
Change committed as 267043

Powered by Google App Engine
This is Rietveld 408576698