Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251173002: Adds tabid to inline signin popup (Closed)

Created:
6 years, 7 months ago by guohui
Modified:
6 years, 7 months ago
Reviewers:
bartfab (slow), xiyuan
CC:
chromium-reviews
Visibility:
Public.

Description

Adds tabid to inline signin popup BUG=363994 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_ui.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 7 months ago (2014-04-28 18:21:15 UTC) #1
xiyuan
lgtm LGTM
6 years, 7 months ago (2014-04-28 18:27:52 UTC) #2
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 7 months ago (2014-04-28 18:55:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/251173002/1
6 years, 7 months ago (2014-04-28 18:56:11 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 00:14:55 UTC) #5
Message was sent while issue was closed. 
Change committed as 266712

Powered by Google App Engine
This is Rietveld 408576698