components/reading_list/ios/reading_list_store.cc - Issue 2511723002: Enable RL sync by default on iOS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/reading_list/ios/reading_list_store.cc

Issue 2511723002: Enable RL sync by default on iOS (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/reading_list/ios/reading_list_store.h ('k') | components/reading_list/ios/reading_list_store_delegate.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/reading_list/reading_list_store.h"	5 #include "components/reading_list/ios/reading_list_store.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "base/memory/ptr_util.h"	9 #include "base/memory/ptr_util.h"

10 #include "components/reading_list/proto/reading_list.pb.h"	10 #include "components/reading_list/ios/proto/reading_list.pb.h"

11 #include "components/reading_list/reading_list_model_impl.h"	11 #include "components/reading_list/ios/reading_list_model_impl.h"

12 #include "components/sync/model/entity_change.h"	12 #include "components/sync/model/entity_change.h"

13 #include "components/sync/model/metadata_batch.h"	13 #include "components/sync/model/metadata_batch.h"

14 #include "components/sync/model/metadata_change_list.h"	14 #include "components/sync/model/metadata_change_list.h"

15 #include "components/sync/model/model_type_change_processor.h"	15 #include "components/sync/model/model_type_change_processor.h"

16 #include "components/sync/model/mutable_data_batch.h"	16 #include "components/sync/model/mutable_data_batch.h"

17 #include "components/sync/model_impl/accumulating_metadata_change_list.h"	17 #include "components/sync/model_impl/accumulating_metadata_change_list.h"

18 #include "components/sync/protocol/model_type_state.pb.h"	18 #include "components/sync/protocol/model_type_state.pb.h"

19	19

20 ReadingListStore::ReadingListStore(	20 ReadingListStore::ReadingListStore(

21 StoreFactoryFunction create_store_callback,	21 StoreFactoryFunction create_store_callback,

(...skipping 429 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
451 // called once when first encountering a remote entity. Local changes will	451 // called once when first encountering a remote entity. Local changes will

452 // provide their storage keys directly to Put instead of using this method.	452 // provide their storage keys directly to Put instead of using this method.

453 // Theoretically this function doesn't need to be stable across multiple calls	453 // Theoretically this function doesn't need to be stable across multiple calls

454 // on the same or different clients, but to keep things simple, it probably	454 // on the same or different clients, but to keep things simple, it probably

455 // should be.	455 // should be.

456 std::string ReadingListStore::GetStorageKey(	456 std::string ReadingListStore::GetStorageKey(

457 const syncer::EntityData& entity_data) {	457 const syncer::EntityData& entity_data) {

458 DCHECK(CalledOnValidThread());	458 DCHECK(CalledOnValidThread());

459 return entity_data.specifics.reading_list().entry_id();	459 return entity_data.specifics.reading_list().entry_id();

460 }	460 }

OLD	NEW