Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2511713002: Implement Android key/value backup (Closed)

Created:
4 years, 1 month ago by aberent
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Implement Android key/value backup This replaces our previous impmentation of (Dolly) Auto Backup. Only the preferences needed to restore the user's signin atate and sync state are backed up. BUG=661188 Review-Url: https://codereview.chromium.org/2496693002 Cr-Commit-Position: refs/heads/master@{#432517} (cherry picked from commit d56b7ec3e6e6c3236835414584f4205283beb218) Committed: https://chromium.googlesource.com/chromium/src/+/9dd9283bac8aa9908d6868a052e088a9839499b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1026 lines, -568 lines) Patch
M chrome/android/java/AndroidManifest.xml View 2 chunks +13 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java View 1 chunk +221 lines, -212 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java View 1 chunk +65 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +1 line, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java View 1 chunk +0 lines, -209 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java View 1 chunk +338 lines, -140 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_backup_agent.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_backup_agent.cc View 1 chunk +121 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_backup_agent_unittest.cc View 1 chunk +142 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_backup_watcher.h View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_backup_watcher.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
aberent
Committed patchset #1 (id:1) manually as 9dd9283bac8aa9908d6868a052e088a9839499b4.
4 years, 1 month ago (2016-11-17 11:40:46 UTC) #2
amineer_google
4 years, 1 month ago (2016-11-18 03:31:18 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2509323004/ by amineer@google.com.

The reason for reverting is: Breaks build.  Please don't reland.

https://uberchromegw.corp.google.com/i/official.android.continuous/builders/b....

Powered by Google App Engine
This is Rietveld 408576698