Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: components/sync/driver/shared_change_processor.cc

Issue 2511703004: [Sync] Remove UIDataTypeController (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/driver/shared_change_processor.h ('k') | components/sync/driver/ui_data_type_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/driver/shared_change_processor.cc
diff --git a/components/sync/driver/shared_change_processor.cc b/components/sync/driver/shared_change_processor.cc
index 514609ee3263d42470a77ba8714ec9260338cab2..9e6ac5a0c43c8ffc0c85d096b85d858054d47c7c 100644
--- a/components/sync/driver/shared_change_processor.cc
+++ b/components/sync/driver/shared_change_processor.cc
@@ -52,6 +52,7 @@ SharedChangeProcessor::~SharedChangeProcessor() {
void SharedChangeProcessor::StartAssociation(
StartDoneCallback start_done,
SyncClient* const sync_client,
+ GenericChangeProcessorFactory* processor_factory,
UserShare* user_share,
std::unique_ptr<DataTypeErrorHandler> error_handler) {
DCHECK(user_share);
@@ -64,10 +65,9 @@ void SharedChangeProcessor::StartAssociation(
// Note that it's possible the shared_change_processor has already been
// disconnected at this point, so all our accesses to the syncer from this
// point on are through it.
- GenericChangeProcessorFactory factory;
local_service_ =
- Connect(sync_client, &factory, user_share, std::move(error_handler),
- weak_ptr_factory.GetWeakPtr());
+ Connect(sync_client, processor_factory, user_share,
+ std::move(error_handler), weak_ptr_factory.GetWeakPtr());
if (!local_service_.get()) {
SyncError error(FROM_HERE, SyncError::DATATYPE_ERROR,
"Failed to connect to syncer.", type_);
« no previous file with comments | « components/sync/driver/shared_change_processor.h ('k') | components/sync/driver/ui_data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698