Deinline PartitionAlloc from DefaultAllocator to reduce code size

Deinline PartitionAlloc from DefaultAllocator to reduce code size

DefaultAllocator calls PartitionAlloc functions from inline methods.
PartitionAlloc consist of always inline functions. This result in a huge
code bloat as DefaultAllocator is used as template argument in wtf templatized
containers. We only need to do the allocation via PartitionAlloc directly when
the container's buffer is created or resized so it doesn't seem to worth the
cost in code size to inline them.

This patch reduced the size of content_shell in my static release build with ~0.5 megabyte.
Reference size: 84514K, 61492K after stripping. Patched: 84083K and 61052K.

This is neutral on Android where -Os already does a good job and deny to inline.

I think we can rely on the performance bots to make sure that this doesn't result in performance regression.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173243

[eseidel, 2014-04-28 18:12:42]

lgtm

[kbalazs, 2014-04-29 16:03:55]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-04-29 16:04:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/251163002/20001

[commit-bot: I haz the power, 2014-04-29 16:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 16:31:13]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink

[kbalazs, 2014-04-29 22:08:14]

On 2014/04/29 16:31:13, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_blink_compile_dbg on tryserver.blink

Anyone has an idea what's wrong on this bot? It builds on mac_blink_rel. It
looks like as the debug bot would just not care about the new file.

Undefined symbols for architecture i386:
  "WTF::DefaultAllocator::backingFree(void*)", referenced from:
      WTF::VectorBuffer<(anonymous namespace)::WrappedInt, 0ul,
WTF::DefaultAllocator>::deallocateBuffer((anonymous namespace)::WrappedInt*) in
wtf_unittests.DequeTest.o
      WTF::VectorBuffer<WTF::OwnPtr<(anonymous namespace)::DestructCounter>,
0ul, WTF::DefaultAllocator>::deallocateBuffer(WTF::OwnPtr<(anonymous
namespace)::DestructCounter>*) in wtf_unittests.DequeTest.o
      WTF::HashTable<void*, void*, WTF::IdentityExtractor, WTF::PtrHash<void*>,
WTF::HashTraits<void*>, WTF::HashTraits<void*>,
WTF::DefaultAllocator>::deleteAllBucketsAndDeallocate(void**, unsigned int) in
wtf_unittests.DequeTest.o
      WTF::VectorBuffer<int, 0ul, WTF::DefaultAllocator>::deallocateBuffer(int*)
in wtf_unittests.DequeTest.o
      WTF::HashTable<int, WTF::KeyValuePair<int, WTF::OwnPtr<(anonymous
namespace)::SimpleClass> >, WTF::KeyValuePairKeyExtractor, WTF::IntHash<unsigned
int>, WTF::HashMapValueTraits<WTF::HashTraits<int>,
WTF::HashTraits<WTF::OwnPtr<(anonymous namespace)::SimpleClass> > >,
WTF::HashTraits<int>,
WTF::DefaultAllocator>::deleteAllBucketsAndDeallocate(WTF::KeyValuePair<int,
WTF::OwnPtr<(anonymous namespace)::SimpleClass> >*, unsigned int) in
wtf_unittests.HashMapTest.o
      WTF::HashTable<WTF::RefPtr<(anonymous namespace)::DummyRefCounted>,
WTF::KeyValuePair<WTF::RefPtr<(anonymous namespace)::DummyRefCounted>, int>,
WTF::KeyValuePairKeyExtractor, WTF::PtrHash<WTF::RefPtr<(anonymous
namespace)::DummyRefCounted> >,
WTF::HashMapValueTraits<WTF::HashTraits<WTF::RefPtr<(anonymous
namespace)::DummyRefCounted> >, WTF::HashTraits<int> >,
WTF::HashTraits<WTF::RefPtr<(anonymous namespace)::DummyRefCounted> >,
WTF::DefaultAllocator>::deleteAllBucketsAndDeallocate(WTF::KeyValuePair<WTF::RefPtr<(anonymous
namespace)::DummyRefCounted>, int>*, unsigned int) in
wtf_unittests.HashMapTest.o
      WTF::HashTable<int, WTF::KeyValuePair<int, WTF::OwnPtr<(anonymous
namespace)::DestructCounter> >, WTF::KeyValuePairKeyExtractor,
WTF::IntHash<unsigned int>, WTF::HashMapValueTraits<WTF::HashTraits<int>,
WTF::HashTraits<WTF::OwnPtr<(anonymous namespace)::DestructCounter> > >,
WTF::HashTraits<int>,
WTF::DefaultAllocator>::deleteAllBucketsAndDeallocate(WTF::KeyValuePair<int,
WTF::OwnPtr<(anonymous namespace)::DestructCounter> >*, unsigned int) in
wtf_unittests.HashMapTest.o
      ...
  "WTF::DefaultAllocator::backingAllocate(unsigned long)", referenced from:
      (anonymous namespace)::WrappedInt*
WTF::DefaultAllocator::backingMalloc<(anonymous namespace)::WrappedInt*,
void>(unsigned long) in wtf_unittests.DequeTest.o
      WTF::OwnPtr<(anonymous namespace)::DestructCounter>*
WTF::DefaultAllocator::backingMalloc<WTF::OwnPtr<(anonymous
namespace)::DestructCounter>*, void>(unsigned long) in wtf_unittests.DequeTest.o
      void** WTF::DefaultAllocator::zeroedBackingMalloc<void**, void>(unsigned
long) in wtf_unittests.DequeTest.o
      int* WTF::DefaultAllocator::backingMalloc<int*, void>(unsigned long) in
wtf_unittests.DequeTest.o
      WTF::KeyValuePair<int, WTF::OwnPtr<(anonymous namespace)::SimpleClass> >*
WTF::DefaultAllocator::zeroedBackingMalloc<WTF::KeyValuePair<int,
WTF::OwnPtr<(anonymous namespace)::SimpleClass> >*, void>(unsigned long) in
wtf_unittests.HashMapTest.o
      WTF::KeyValuePair<WTF::RefPtr<(anonymous namespace)::DummyRefCounted>,
int>*
WTF::DefaultAllocator::zeroedBackingMalloc<WTF::KeyValuePair<WTF::RefPtr<(anonymous
namespace)::DummyRefCounted>, int>*, void>(unsigned long) in
wtf_unittests.HashMapTest.o
      WTF::KeyValuePair<int, WTF::OwnPtr<(anonymous namespace)::DestructCounter>
>* WTF::DefaultAllocator::zeroedBackingMalloc<WTF::KeyValuePair<int,
WTF::OwnPtr<(anonymous namespace)::DestructCounter> >*, void>(unsigned long) in
wtf_unittests.HashMapTest.o
      ...
ld: symbol(s) not found for architecture i386
clang:error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

[kbalazs, 2014-05-02 21:09:54]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-05-02 21:10:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/251163002/40001

[commit-bot: I haz the power, 2014-05-02 22:43:32]

Change committed as 173243