Media: Don't suspend streaming media on Desktop.

media/blink/webmediaplayer_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <stdint.h>
 
 #include <memory>
 
@@ skipping 169 matching lines @@
 
   void OnMetadata(PipelineMetadata metadata) { wmpi_->OnMetadata(metadata); }
 
   void OnVideoNaturalSizeChange(const gfx::Size& size) {
     wmpi_->OnVideoNaturalSizeChange(size);
   }
 
   WebMediaPlayerImpl::PlayState ComputePlayState() {
     wmpi_->is_idle_ = false;
     wmpi_->must_suspend_ = false;
-    return wmpi_->UpdatePlayState_ComputePlayState(false, false, false);
+    return wmpi_->UpdatePlayState_ComputePlayState(false, false, false, false);
   }
 
   WebMediaPlayerImpl::PlayState ComputePlayStateSuspended() {
     wmpi_->is_idle_ = false;
     wmpi_->must_suspend_ = false;
-    return wmpi_->UpdatePlayState_ComputePlayState(false, true, false);
+    return wmpi_->UpdatePlayState_ComputePlayState(false, false, true, false);
   }
 
   WebMediaPlayerImpl::PlayState ComputeBackgroundedPlayState() {
     wmpi_->is_idle_ = false;
     wmpi_->must_suspend_ = false;
-    return wmpi_->UpdatePlayState_ComputePlayState(false, false, true);
+    return wmpi_->UpdatePlayState_ComputePlayState(false, false, false, true);
   }
 
   WebMediaPlayerImpl::PlayState ComputeIdlePlayState() {
     wmpi_->is_idle_ = true;
     wmpi_->must_suspend_ = false;
-    return wmpi_->UpdatePlayState_ComputePlayState(false, false, false);
+    return wmpi_->UpdatePlayState_ComputePlayState(false, false, false, false);
   }
 
   WebMediaPlayerImpl::PlayState ComputeIdleSuspendedPlayState() {
     wmpi_->is_idle_ = true;
     wmpi_->must_suspend_ = false;
-    return wmpi_->UpdatePlayState_ComputePlayState(false, true, false);
+    return wmpi_->UpdatePlayState_ComputePlayState(false, false, true, false);
   }
 
   WebMediaPlayerImpl::PlayState ComputeMustSuspendPlayState() {
     wmpi_->is_idle_ = false;
     wmpi_->must_suspend_ = true;
-    return wmpi_->UpdatePlayState_ComputePlayState(false, false, false);
+    return wmpi_->UpdatePlayState_ComputePlayState(false, false, false, false);
+  }
+
+  WebMediaPlayerImpl::PlayState ComputeStreamingPlayState(bool must_suspend) {
+    wmpi_->is_idle_ = true;
+    wmpi_->must_suspend_ = must_suspend;
+    return wmpi_->UpdatePlayState_ComputePlayState(false, true, false, true);
   }
 
   void SetDelegateState(WebMediaPlayerImpl::DelegateState state) {
     wmpi_->SetDelegateState(state);
   }
 
   bool IsSuspended() { return wmpi_->pipeline_controller_.IsSuspended(); }
 
   void AddBufferedRanges() {
     wmpi_->buffered_data_source_host_.AddBufferedByteRange(0, 1);
@@ skipping 330 matching lines @@
   EXPECT_EQ(WebMediaPlayerImpl::DelegateState::ENDED, state.delegate_state);
   EXPECT_FALSE(state.is_memory_reporting_enabled);
   EXPECT_FALSE(state.is_suspended);
 
   state = ComputeIdlePlayState();
   EXPECT_EQ(WebMediaPlayerImpl::DelegateState::ENDED, state.delegate_state);
   EXPECT_FALSE(state.is_memory_reporting_enabled);
   EXPECT_TRUE(state.is_suspended);
 }
 
+TEST_F(WebMediaPlayerImplTest, ComputePlayState_Streaming) {
+  InitializeWebMediaPlayerImpl();
+  WebMediaPlayerImpl::PlayState state;
+  SetMetadata(true, true);
+
+  SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
+  SetPaused(true);
+
+  // Streaming media should not suspend, even if paused, idle, and backgrounded.
+  state = ComputeStreamingPlayState(false);
+  EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PAUSED, state.delegate_state);
+  EXPECT_FALSE(state.is_memory_reporting_enabled);
+  EXPECT_FALSE(state.is_suspended);
+
+  // Streaming media should suspend when the tab is closed, regardless.
+  state = ComputeStreamingPlayState(true);
+  EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state);
+  EXPECT_FALSE(state.is_memory_reporting_enabled);
+  EXPECT_TRUE(state.is_suspended);
+}
+
 TEST_F(WebMediaPlayerImplTest, ComputePlayState_Suspended) {
   InitializeWebMediaPlayerImpl();
   WebMediaPlayerImpl::PlayState state;
   SetMetadata(true, true);
 
   // Suspended players should be resumed unless we have reached the appropriate
   // ready state and are not seeking.
   SetPaused(true);
   state = ComputePlayStateSuspended();
   EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state);
@@ skipping 137 matching lines @@
   EXPECT_CALL(delegate_, DidPlay(_, true, false, false, _));
   client_.set_is_autoplaying_muted(true);
   SetDelegateState(WebMediaPlayerImpl::DelegateState::PLAYING);
 
   EXPECT_CALL(delegate_, DidPlay(_, true, true, false, _));
   client_.set_is_autoplaying_muted(false);
   wmpi_->setVolume(1.0);
 }
 
 }  // namespace media