Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2511543002: Add missing canonicalization of cloned uninstantiated types when cloning (Closed)

Created:
4 years, 1 month ago by regis
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing canonicalization of cloned uninstantiated types when cloning functions for mixins (fixes #27606). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/10434a66a072377be02d545fdcc864dcec671e26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/object.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 1 month ago (2016-11-16 20:40:27 UTC) #2
rmacnak
lgtm
4 years, 1 month ago (2016-11-16 21:24:54 UTC) #3
regis
4 years, 1 month ago (2016-11-16 21:45:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10434a66a072377be02d545fdcc864dcec671e26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698