Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2511533002: Add support for single line enums to java_cpp_enum.py. (Closed)

Created:
4 years, 1 month ago by estevenson
Modified:
4 years, 1 month ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for single line enums to java_cpp_enum.py. This CL changes java_cpp_enum.py to handle single line enums. E.g. // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.notifications enum NotificationActionType { BUTTON, TEXT }; BUG=657847 Committed: https://crrev.com/4fdbbc3aeeb41eed8b6a65f29662ebb7865b0af0 Cr-Commit-Position: refs/heads/master@{#432661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
M build/android/gyp/java_cpp_enum.py View 5 chunks +17 lines, -4 lines 0 comments Download
M build/android/gyp/java_cpp_enum_tests.py View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
estevenson
ptal Andrew! Note that this CL only handles multiple enum entries on the same line ...
4 years, 1 month ago (2016-11-16 20:53:50 UTC) #4
agrieve
On 2016/11/16 20:53:50, estevenson wrote: > ptal Andrew! > > Note that this CL only ...
4 years, 1 month ago (2016-11-16 21:04:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511533002/1
4 years, 1 month ago (2016-11-16 22:51:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 23:37:27 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 23:43:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fdbbc3aeeb41eed8b6a65f29662ebb7865b0af0
Cr-Commit-Position: refs/heads/master@{#432661}

Powered by Google App Engine
This is Rietveld 408576698