Fix ia32 build: there are no patchable calls on ia32

Fix ia32 build: there are no patchable calls on ia32

Committed: https://github.com/dart-lang/sdk/commit/e2a08259e9056a393300c018ddbc72c0a28e6239

[kustermann, 2016-11-16 20:14:54]

kustermann@google.com changed reviewers:
+ fschneider@google.com, vegorov@google.com

[kustermann, 2016-11-16 20:15:16]

TBR (broke build)

[kustermann, 2016-11-16 20:15:25]

Description was changed from

==========
Fix ia32 build: there are no patchable calls on ia32
==========

to

==========
Fix ia32 build: there are no patchable calls on ia32

Committed:
https://github.com/dart-lang/sdk/commit/e2a08259e9056a393300c018ddbc72c0a28e6239
==========

[kustermann, 2016-11-16 20:15:27]

Committed patchset #1 (id:1) manually as
e2a08259e9056a393300c018ddbc72c0a28e6239 (presubmit successful).

[Florian Schneider, 2016-11-16 20:37:03]

https://codereview.chromium.org/2511513003/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/2511513003/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler_ia32.cc:1102: LocationSummary* locs) {
I'd rather remove this method, and replace the call-sites with GenerateCall.

This way, there will be a compile-time error if one want to generate a patchable
call on ia32.

[kustermann, 2016-11-16 20:45:32]

https://codereview.chromium.org/2511513003/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/2511513003/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler_ia32.cc:1102: LocationSummary* locs) {
On 2016/11/16 20:37:03, Florian Schneider wrote:
> I'd rather remove this method, and replace the call-sites with GenerateCall.
> 
> This way, there will be a compile-time error if one want to generate a
patchable
> call on ia32.

I can do that - though it's slightly weired since the FlowGraphCompiler will
still have the method declaration in the header file.

[Florian Schneider, 2016-11-16 20:50:13]

https://codereview.chromium.org/2511513003/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/2511513003/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler_ia32.cc:1102: LocationSummary* locs) {
On 2016/11/16 20:45:32, kustermann wrote:
> On 2016/11/16 20:37:03, Florian Schneider wrote:
> > I'd rather remove this method, and replace the call-sites with GenerateCall.
> > 
> > This way, there will be a compile-time error if one want to generate a
> patchable
> > call on ia32.
> 
> I can do that - though it's slightly weired since the FlowGraphCompiler will
> still have the method declaration in the header file.

We do that already in many places. Sometimes we make the body just UNREACHABLE()
(e.g. if it is used a lot from architecture-independent code, but that's not the
case here)