Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2511503002: [wasm] Break a cycle with a loop node in the int64-lowering. (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
titzer
CC:
Mircea Trofin, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Break a cycle with a loop node in the int64-lowering. The control edges in a TurboFan graph can form a cycle. To break this cycle in the int64-lowering we add special handling for loop nodes. Similar handling already exists for phi nodes and effectphi nodes, which breaks cycles formed by value edges and effect edges, respectively. Committed: https://crrev.com/020e2c8d267217a789b80fabf460ebaf37ca964d Cr-Commit-Position: refs/heads/master@{#41071}

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/compiler/int64-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
ahaas
4 years, 1 month ago (2016-11-17 10:54:46 UTC) #11
titzer
On 2016/11/17 10:54:46, ahaas wrote: lgtm
4 years, 1 month ago (2016-11-17 10:55:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511503002/20001
4 years, 1 month ago (2016-11-17 11:27:16 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 11:50:42 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:04 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/020e2c8d267217a789b80fabf460ebaf37ca964d
Cr-Commit-Position: refs/heads/master@{#41071}

Powered by Google App Engine
This is Rietveld 408576698