Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2511473002: Re-enable foreign-fetch-cors layout test. (Closed)

Created:
4 years, 1 month ago by Marijn Kruisselbrink
Modified:
4 years, 1 month ago
Reviewers:
jsbell
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable foreign-fetch-cors layout test. With recent fixes in testharness.js and testharnessreport.js this test should no longer be failing. Maybe this test should be added to SlowTests instead but for now it seems to be fast enough to not get too close to the actual test timeout. BUG=640947 Committed: https://crrev.com/bdd208fae216332c37dfc202d77cf04cd8a1fbd6 Cr-Commit-Position: refs/heads/master@{#432629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Marijn Kruisselbrink
4 years, 1 month ago (2016-11-16 19:37:00 UTC) #10
jsbell
lgtm
4 years, 1 month ago (2016-11-16 20:35:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511473002/1
4 years, 1 month ago (2016-11-16 21:13:48 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 21:21:02 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 21:39:32 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdd208fae216332c37dfc202d77cf04cd8a1fbd6
Cr-Commit-Position: refs/heads/master@{#432629}

Powered by Google App Engine
This is Rietveld 408576698