Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2511423002: [ObjC ARC] Converts ios/chrome/browser/ui/commands:unit_tests to ARC.Automatically generated ARCM… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/commands:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/a34599dd9fd9f5cbfff9316f6d5de97f78f9b204 Cr-Commit-Position: refs/heads/master@{#436284}

Patch Set 1 #

Patch Set 2 : removed scoped nsobjects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M ios/chrome/browser/ui/commands/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/commands/set_up_for_testing_command_unittest.mm View 1 8 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
stkhapugin
PTAL. Passes downstream tests
4 years, 1 month ago (2016-11-18 18:23:11 UTC) #4
stkhapugin
ping
4 years, 1 month ago (2016-11-22 17:31:22 UTC) #7
sdefresne
lgtm
4 years ago (2016-11-23 09:39:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511423002/1
4 years ago (2016-11-24 12:52:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/279250)
4 years ago (2016-11-24 15:14:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511423002/1
4 years ago (2016-11-24 15:17:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/277535)
4 years ago (2016-11-24 15:33:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511423002/20001
4 years ago (2016-12-05 13:35:21 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 14:27:14 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-05 14:30:16 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a34599dd9fd9f5cbfff9316f6d5de97f78f9b204
Cr-Commit-Position: refs/heads/master@{#436284}

Powered by Google App Engine
This is Rietveld 408576698