Send IndexedDB observations through IDBDatabaseCallbacks.

Send IndexedDB observations through IDBDatabaseCallbacks.

This change refactors IndexedDB observations that they are transmitted
through the same DatabaseCallbacks Mojo interface as other out-of-band
database events. This means we can delete a lot of code that existed
specifically to support observers in the Blink public API and remove
the last remaining legacy IPC messages from indexed_db_messages.h.

Note, indexed_db_messages.h remains after this change because removing
it causes a lot of unrelated code churn.

BUG=627484
Committed: https://crrev.com/8f7a4e424f50eec24ec03e2e11f7048b1a3f6b0b
Cr-Commit-Position: refs/heads/master@{#434781}

[Reilly Grant (use Gerrit), 2016-11-19 00:42:21]

reillyg@chromium.org changed reviewers:
+ jsbell@chromium.org, kenrb@chromium.org

[Reilly Grant (use Gerrit), 2016-11-19 00:42:22]

kenrb@ for IPC security review.
jsbell@ for IndexedDB review.

[Reilly Grant (use Gerrit), 2016-11-19 00:42:54]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 00:43:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-11-19 00:47:37]

jsbell@chromium.org changed reviewers:
+ dmurph@chromium.org

[jsbell, 2016-11-19 00:47:38]

dmurph - can you review the observer changes too?

[commit-bot: I haz the power, 2016-11-19 00:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 00:49:29]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Reilly Grant (use Gerrit), 2016-11-19 01:32:06]

Rebased.

[Reilly Grant (use Gerrit), 2016-11-19 01:32:52]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 01:33:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 01:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 01:38:21]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jsbell, 2016-11-21 19:45:22]

lgtm

https://codereview.chromium.org/2511403003/diff/20001/content/common/indexed_...
File content/common/indexed_db/indexed_db.mojom (right):

https://codereview.chromium.org/2511403003/diff/20001/content/common/indexed_...
content/common/indexed_db/indexed_db.mojom:152: map<int32, array<int32>>
observation_index_map;
Can we document what this is a map from/to?

IIRC this maps observer id to the associated observations (below) by index.

https://codereview.chromium.org/2511403003/diff/20001/content/common/indexed_...
File content/common/indexed_db/indexed_db_messages.h (right):

https://codereview.chromium.org/2511403003/diff/20001/content/common/indexed_...
content/common/indexed_db/indexed_db_messages.h:9: #define IPC_MESSAGE_START
IndexedDBMsgStart
Heh, this file becomes awesome. :)

[dmurph, 2016-11-21 22:13:36]

observer bits lgtm

[Reilly Grant (use Gerrit), 2016-11-22 21:02:54]

kenrb@, ping.

[Reilly Grant (use Gerrit), 2016-11-23 01:27:27]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 01:28:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 02:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 02:04:19]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Reilly Grant (use Gerrit), 2016-11-23 02:40:20]

Fix build.

[Reilly Grant (use Gerrit), 2016-11-23 02:41:56]

reillyg@chromium.org changed reviewers:
+ pfeldman@chromium.org

[Reilly Grant (use Gerrit), 2016-11-23 02:41:57]

pfeldman@, please review the following:

content/browser/BUILD.gn
content/child/BUILD.gn
content/common/BUILD.gn
content/renderer/render_thread_impl.cc
third_party/WebKit/public/BUILD.gn

[Reilly Grant (use Gerrit), 2016-11-23 05:12:32]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 05:12:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 06:14:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 06:14:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kenrb, 2016-11-23 17:12:55]

Sorry for the delay.

ipc lgtm

[pfeldman, 2016-11-23 19:09:53]

lgtm

[Reilly Grant (use Gerrit), 2016-11-23 19:25:57]

Remove FuzzTraits for removed ParamTraits.

[Reilly Grant (use Gerrit), 2016-11-23 19:26:25]

reillyg@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Reilly Grant (use Gerrit), 2016-11-23 19:26:26]

mbarbella@ for fuzzer.cc changes.

[Reilly Grant (use Gerrit), 2016-11-23 19:26:51]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 19:27:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 21:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 21:44:07]

Dry run: This issue passed the CQ dry run.

[Martin Barbella, 2016-11-28 02:18:24]

On 2016/11/23 19:26:26, Reilly Grant wrote:
> mbarbella@ for fuzzer.cc changes.

fuzzer.cc lgtm. Sorry for the delay.

[Reilly Grant (use Gerrit), 2016-11-28 05:52:21]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-11-28 05:52:22]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org,
dmurph@chromium.org, kenrb@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2511403003/#ps60001
(title: "Remove FuzzTraits for removed ParamTraits.")

[commit-bot: I haz the power, 2016-11-28 05:52:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 05:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 05:59:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Reilly Grant (use Gerrit), 2016-11-28 18:18:37]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-11-28 18:18:37]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
mbarbella@chromium.org, jsbell@chromium.org, pfeldman@chromium.org,
dmurph@chromium.org
Link to the patchset: https://codereview.chromium.org/2511403003/#ps80001
(title: "Remove unnecessary forward declaration.")

[commit-bot: I haz the power, 2016-11-28 18:19:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 19:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:48:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Reilly Grant (use Gerrit), 2016-11-28 19:51:20]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:52:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 23:53:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480362680135250,
"parent_rev": "5a3ebfc0eff6abdf5d2b470314026e623af9909e", "commit_rev":
"c67f2e433332602278a9641c8ddabc08f81729c4"}

[commit-bot: I haz the power, 2016-11-28 23:53:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-28 23:56:47]

Description was changed from

==========
Send IndexedDB observations through IDBDatabaseCallbacks.

This change refactors IndexedDB observations that they are transmitted
through the same DatabaseCallbacks Mojo interface as other out-of-band
database events. This means we can delete a lot of code that existed
specifically to support observers in the Blink public API and remove
the last remaining legacy IPC messages from indexed_db_messages.h.

Note, indexed_db_messages.h remains after this change because removing
it causes a lot of unrelated code churn.

BUG=627484
==========

to

==========
Send IndexedDB observations through IDBDatabaseCallbacks.

This change refactors IndexedDB observations that they are transmitted
through the same DatabaseCallbacks Mojo interface as other out-of-band
database events. This means we can delete a lot of code that existed
specifically to support observers in the Blink public API and remove
the last remaining legacy IPC messages from indexed_db_messages.h.

Note, indexed_db_messages.h remains after this change because removing
it causes a lot of unrelated code churn.

BUG=627484

Committed: https://crrev.com/8f7a4e424f50eec24ec03e2e11f7048b1a3f6b0b
Cr-Commit-Position: refs/heads/master@{#434781}
==========

[commit-bot: I haz the power, 2016-11-28 23:56:49]

Patchset 5 (id:??) landed as
https://crrev.com/8f7a4e424f50eec24ec03e2e11f7048b1a3f6b0b
Cr-Commit-Position: refs/heads/master@{#434781}