Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2511403002: Compute [WorldImpact] for main method as entrypoint (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute [WorldImpact] for main method as entrypoint R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/8da63799a033e8ad3384fac5f0512b8d8b6ee4d3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -103 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 chunks +8 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 3 chunks +19 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 5 chunks +51 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 5 chunks +42 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 2 chunks +20 lines, -62 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
4 years, 1 month ago (2016-11-18 14:41:52 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2511403002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2511403002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode688 pkg/compiler/lib/src/compiler.dart:688: backend.backendClasses.listImplementation.ensureResolved(resolution); don't we only need to resolve List ...
4 years, 1 month ago (2016-11-18 17:40:21 UTC) #3
Harry Terkelsen
lgtm lgtm
4 years, 1 month ago (2016-11-18 17:40:22 UTC) #4
Johnni Winther
Committed patchset #2 (id:20001) manually as 8da63799a033e8ad3384fac5f0512b8d8b6ee4d3 (presubmit successful).
4 years, 1 month ago (2016-11-21 09:59:11 UTC) #6
Johnni Winther
4 years, 1 month ago (2016-11-21 12:45:10 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2511403002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2511403002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:688:
backend.backendClasses.listImplementation.ensureResolved(resolution);
On 2016/11/18 17:40:21, Harry Terkelsen wrote:
> don't we only need to resolve List and String if main has arguments?

Moved these into the backend.

Powered by Google App Engine
This is Rietveld 408576698