Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2511363002: Build native client files only if enable_nacl is true. (Closed)

Created:
4 years, 1 month ago by Ossy
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build native client files only if enable_nacl is true. Native client is unsupported on AArch64 Linux and building its files unconditionally caused build failure. BUG=666690 Committed: https://crrev.com/d584dd76b4215a83da850bbfcdd0fdb2527e9c57 Cr-Commit-Position: refs/heads/master@{#433511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Ossy
4 years, 1 month ago (2016-11-18 17:27:01 UTC) #3
brettw
lgtm
4 years, 1 month ago (2016-11-18 21:11:59 UTC) #4
brettw
(In the future, you only need to ask one reviewer.)
4 years, 1 month ago (2016-11-18 21:12:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511363002/1
4 years, 1 month ago (2016-11-21 09:29:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 11:36:44 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 11:39:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d584dd76b4215a83da850bbfcdd0fdb2527e9c57
Cr-Commit-Position: refs/heads/master@{#433511}

Powered by Google App Engine
This is Rietveld 408576698