Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: third_party/WebKit/LayoutTests/PRESUBMIT.py

Issue 2511333002: Cleanup after enabling WPTServe. (Closed)
Patch Set: Update a comment, remove the right testharnessreport.js Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """LayoutTests/ presubmit script for Blink. 5 """LayoutTests/ presubmit script for Blink.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 def _CheckIdenticalFiles(input_api, output_api): 58 def _CheckIdenticalFiles(input_api, output_api):
59 """Verifies that certain files are identical in various locations. 59 """Verifies that certain files are identical in various locations.
60 60
61 These files should always be updated together. If this list is modified, 61 These files should always be updated together. If this list is modified,
62 consider also changing the list of files to copy from web-platform-tests 62 consider also changing the list of files to copy from web-platform-tests
63 when importing in Tools/Scripts/webkitpy/deps_updater.py. 63 when importing in Tools/Scripts/webkitpy/deps_updater.py.
64 """ 64 """
65 dirty_files = set(input_api.LocalPaths()) 65 dirty_files = set(input_api.LocalPaths())
66 66
67 # TODO(tkent): Remove vendor-prefix.js, testharnessreport.js, and
68 # WebIDLParser.js from |groups| after enabling WPTServe.
69 groups = [ 67 groups = [
70 ('external/wpt/common/vendor-prefix.js', 'resources/vendor-prefix.js'),
71 ('external/wpt/resources/idlharness.js', 'resources/idlharness.js'), 68 ('external/wpt/resources/idlharness.js', 'resources/idlharness.js'),
72 ('external/wpt/resources/testharness.js', 'resources/testharness.js'), 69 ('external/wpt/resources/testharness.js', 'resources/testharness.js'),
73 ('external/wpt/resources/testharnessreport.js', 'resources/testharnessre port.js'),
74 ('external/wpt/resources/WebIDLParser.js', 'resources/WebIDLParser.js'),
75 ] 70 ]
76 71
77 def _absolute_path(s): 72 def _absolute_path(s):
78 return input_api.os_path.join(input_api.PresubmitLocalPath(), *s.split(' /')) 73 return input_api.os_path.join(input_api.PresubmitLocalPath(), *s.split(' /'))
79 74
80 def _local_path(s): 75 def _local_path(s):
81 return input_api.os_path.join('third_party', 'WebKit', 'LayoutTests', *s .split('/')) 76 return input_api.os_path.join('third_party', 'WebKit', 'LayoutTests', *s .split('/'))
82 77
83 errors = [] 78 errors = []
84 for group in groups: 79 for group in groups:
(...skipping 12 matching lines...) Expand all
97 results.extend(_CheckTestharnessResults(input_api, output_api)) 92 results.extend(_CheckTestharnessResults(input_api, output_api))
98 results.extend(_CheckIdenticalFiles(input_api, output_api)) 93 results.extend(_CheckIdenticalFiles(input_api, output_api))
99 return results 94 return results
100 95
101 96
102 def CheckChangeOnCommit(input_api, output_api): 97 def CheckChangeOnCommit(input_api, output_api):
103 results = [] 98 results = []
104 results.extend(_CheckTestharnessResults(input_api, output_api)) 99 results.extend(_CheckTestharnessResults(input_api, output_api))
105 results.extend(_CheckIdenticalFiles(input_api, output_api)) 100 results.extend(_CheckIdenticalFiles(input_api, output_api))
106 return results 101 return results
OLDNEW
« no previous file with comments | « content/shell/renderer/layout_test/blink_test_runner.cc ('k') | third_party/WebKit/LayoutTests/W3CImportExpectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698