Chromium Code Reviews| Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp |
| diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp |
| index e37bab8f41fb3cd57780894d6d214d312bd63b80..8351dc93ff48d239dd694680df724daae795e441 100644 |
| --- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp |
| +++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp |
| @@ -103,6 +103,19 @@ bool IsCrossOrigin(const KURL& a, const KURL& b) { |
| return !originB->isSameSchemeHostPort(originA.get()); |
| } |
| +void addRedirectsToTimingInfo(Resource* resource, ResourceTimingInfo* info) { |
| + // Store redirect responses that were packed inside the final response. |
| + const Vector<ResourceResponse>& responses = |
|
Yoav Weiss
2016/12/09 00:11:13
Nit: const auto&
sunjian
2016/12/09 00:50:12
Done.
|
| + resource->response().redirectResponses(); |
| + for (size_t i = 0; i < responses.size(); ++i) { |
| + const KURL& newURL = i + 1 < responses.size() |
| + ? KURL(responses[i + 1].url()) |
| + : resource->resourceRequest().url(); |
| + bool crossOrigin = IsCrossOrigin(responses[i].url(), newURL); |
| + info->addRedirect(responses[i], crossOrigin); |
| + } |
| +} |
| + |
| } // namespace |
| static void RecordSriResourceIntegrityMismatchEvent( |
| @@ -597,7 +610,6 @@ Resource* ResourceFetcher::requestResource( |
| resource->setLinkPreload(false); |
| break; |
| } |
| - |
| if (!resource) |
| return nullptr; |
| if (resource->getType() != factory.type()) { |
| @@ -641,7 +653,6 @@ Resource* ResourceFetcher::requestResource( |
| if (!startLoad(resource)) |
| return nullptr; |
| - |
| scopedResourceLoadTracker.resourceLoadContinuesBeyondScope(); |
| DCHECK(!resource->errorOccurred() || |
| @@ -757,7 +768,7 @@ Resource* ResourceFetcher::createResourceForLoading( |
| return resource; |
| } |
| -void ResourceFetcher::storeResourceTimingInitiatorInformation( |
| +void ResourceFetcher::storePerformanceTimingInitiatorInformation( |
| Resource* resource) { |
| const AtomicString& fetchInitiator = resource->options().initiatorInfo.name; |
| if (fetchInitiator == FetchInitiatorTypeNames::internal) |
| @@ -771,6 +782,14 @@ void ResourceFetcher::storeResourceTimingInitiatorInformation( |
| ? resource->resourceRequest().navigationStartTime() |
| : monotonicallyIncreasingTime(); |
| + // This buffer is created and populated for providing transferSize |
| + // and Redirect timing opt in information. |
| + if (isMainResource) { |
| + DCHECK(!m_navigationTimingInfo); |
| + m_navigationTimingInfo = |
| + ResourceTimingInfo::create(fetchInitiator, startTime, isMainResource); |
| + } |
| + |
| std::unique_ptr<ResourceTimingInfo> info = |
| ResourceTimingInfo::create(fetchInitiator, startTime, isMainResource); |
| @@ -782,8 +801,9 @@ void ResourceFetcher::storeResourceTimingInitiatorInformation( |
| } |
| if (!isMainResource || |
| - context().updateTimingInfoForIFrameNavigation(info.get())) |
| + context().updateTimingInfoForIFrameNavigation(info.get())) { |
| m_resourceTimingInfoMap.add(resource, std::move(info)); |
| + } |
| } |
| ResourceFetcher::RevalidationPolicy |
| @@ -1125,6 +1145,10 @@ ArchiveResource* ResourceFetcher::createArchive(Resource* resource) { |
| return m_archive ? m_archive->mainResource() : nullptr; |
| } |
| +ResourceTimingInfo* ResourceFetcher::getNavigationTimingInfo() { |
| + return m_navigationTimingInfo.get(); |
| +} |
| + |
| void ResourceFetcher::didFinishLoading(Resource* resource, |
| double finishTime, |
| DidFinishLoadingReason finishReason) { |
| @@ -1143,18 +1167,17 @@ void ResourceFetcher::didFinishLoading(Resource* resource, |
| DCHECK(finishReason == DidFinishFirstPartInMultipart || |
| !m_nonBlockingLoaders.contains(resource->loader())); |
| + if (resource->getType() == Resource::MainResource) { |
| + DCHECK(m_navigationTimingInfo); |
| + // Store redirect responses that were packed inside the final response. |
| + addRedirectsToTimingInfo(resource, m_navigationTimingInfo.get()); |
| + m_navigationTimingInfo->addFinalTransferSize( |
| + encodedDataLength == -1 ? 0 : encodedDataLength); |
| + } |
| if (std::unique_ptr<ResourceTimingInfo> info = |
| m_resourceTimingInfoMap.take(resource)) { |
| // Store redirect responses that were packed inside the final response. |
| - const Vector<ResourceResponse>& responses = |
| - resource->response().redirectResponses(); |
| - for (size_t i = 0; i < responses.size(); ++i) { |
| - const KURL& newURL = i + 1 < responses.size() |
| - ? KURL(responses[i + 1].url()) |
| - : resource->resourceRequest().url(); |
| - bool crossOrigin = IsCrossOrigin(responses[i].url(), newURL); |
| - info->addRedirect(responses[i], crossOrigin); |
| - } |
| + addRedirectsToTimingInfo(resource, info.get()); |
| if (resource->response().isHTTP() && |
| resource->response().httpStatusCode() < 400) { |
| @@ -1323,7 +1346,7 @@ bool ResourceFetcher::startLoad(Resource* resource) { |
| else |
| m_nonBlockingLoaders.add(loader); |
| - storeResourceTimingInitiatorInformation(resource); |
| + storePerformanceTimingInitiatorInformation(resource); |
| resource->setFetcherSecurityOrigin(sourceOrigin); |
| loader->activateCacheAwareLoadingIfNeeded(request); |
| @@ -1416,6 +1439,13 @@ ResourceRequestBlockedReason ResourceFetcher::willFollowRedirect( |
| bool crossOrigin = IsCrossOrigin(redirectResponse.url(), newRequest.url()); |
| it->value->addRedirect(redirectResponse, crossOrigin); |
| } |
| + |
| + if (resource->getType() == Resource::MainResource) { |
| + DCHECK(m_navigationTimingInfo); |
| + bool crossOrigin = IsCrossOrigin(redirectResponse.url(), newRequest.url()); |
| + m_navigationTimingInfo->addRedirect(redirectResponse, crossOrigin); |
| + } |
| + |
| newRequest.setAllowStoredCredentials(resource->options().allowCredentials == |
| AllowStoredCredentials); |
| willSendRequest(resource->identifier(), newRequest, redirectResponse, |