Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2511313002: transferSize implementation (Closed)
Patch Set: Got rid of DCHECKS cause they don't stand any more Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index cb7b2cccaaab98ed31825e0f51f7e26352b45a12..91c65c2ec983a9a7d7c654c67975ba76079800f4 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -103,6 +103,19 @@ bool IsCrossOrigin(const KURL& a, const KURL& b) {
return !originB->isSameSchemeHostPort(originA.get());
}
+void addRedirectsToTimingInfo(Resource* resource, ResourceTimingInfo* info) {
+ // Store redirect responses that were packed inside the final response.
+ const Vector<ResourceResponse>& responses =
+ resource->response().redirectResponses();
+ for (size_t i = 0; i < responses.size(); ++i) {
+ const KURL& newURL = i + 1 < responses.size()
+ ? KURL(responses[i + 1].url())
+ : resource->resourceRequest().url();
+ bool crossOrigin = IsCrossOrigin(responses[i].url(), newURL);
+ info->addRedirect(responses[i], crossOrigin);
+ }
+}
+
} // namespace
static void RecordSriResourceIntegrityMismatchEvent(
@@ -243,6 +256,7 @@ ResourceFetcher::ResourceFetcher(FetchContext* newContext)
m_resourceTimingReportTimer(
this,
&ResourceFetcher::resourceTimingReportTimerFired),
+ m_mainResourceIdentifier(0),
m_autoLoadImages(true),
m_imagesEnabled(true),
m_allowStaleResources(false),
@@ -753,7 +767,7 @@ Resource* ResourceFetcher::createResourceForLoading(
return resource;
}
-void ResourceFetcher::storeResourceTimingInitiatorInformation(
+void ResourceFetcher::storePerformanceTimingInitiatorInformation(
Resource* resource) {
const AtomicString& fetchInitiator = resource->options().initiatorInfo.name;
if (fetchInitiator == FetchInitiatorTypeNames::internal)
@@ -778,8 +792,13 @@ void ResourceFetcher::storeResourceTimingInitiatorInformation(
}
if (!isMainResource ||
- context().updateTimingInfoForIFrameNavigation(info.get()))
+ context().updateTimingInfoForIFrameNavigation(info.get())) {
m_resourceTimingInfoMap.add(resource, std::move(info));
+ } else {
+ DCHECK(!m_mainResourceTimingInfo);
+ m_mainResourceTimingInfo = std::move(info);
+ m_mainResourceIdentifier = resource->identifier();
Yoav Weiss 2016/12/05 19:21:04 Can you add a DCHECK here to make sure the resourc
sunjian 2016/12/07 19:09:50 Done.
+ }
}
ResourceFetcher::RevalidationPolicy
@@ -1121,6 +1140,12 @@ ArchiveResource* ResourceFetcher::createArchive(Resource* resource) {
return m_archive ? m_archive->mainResource() : nullptr;
}
+// m_mainResourceTimingInfo can be null if it is an iframe navigation restored
+// from history.
+ResourceTimingInfo* ResourceFetcher::getMainResourceTimingInfo() {
+ return m_mainResourceTimingInfo.get();
+}
+
void ResourceFetcher::didFinishLoading(Resource* resource,
double finishTime,
DidFinishLoadingReason finishReason) {
@@ -1139,18 +1164,18 @@ void ResourceFetcher::didFinishLoading(Resource* resource,
DCHECK(finishReason == DidFinishFirstPartInMultipart ||
!m_nonBlockingLoaders.contains(resource->loader()));
+ if (resource->getType() == Resource::MainResource &&
+ resource->identifier() == m_mainResourceIdentifier) {
+ DCHECK(m_mainResourceTimingInfo);
+ // Store redirect responses that were packed inside the final response.
+ addRedirectsToTimingInfo(resource, m_mainResourceTimingInfo.get());
+ m_mainResourceTimingInfo->addFinalTransferSize(
+ encodedDataLength == -1 ? 0 : encodedDataLength);
+ }
if (std::unique_ptr<ResourceTimingInfo> info =
m_resourceTimingInfoMap.take(resource)) {
// Store redirect responses that were packed inside the final response.
- const Vector<ResourceResponse>& responses =
- resource->response().redirectResponses();
- for (size_t i = 0; i < responses.size(); ++i) {
- const KURL& newURL = i + 1 < responses.size()
- ? KURL(responses[i + 1].url())
- : resource->resourceRequest().url();
- bool crossOrigin = IsCrossOrigin(responses[i].url(), newURL);
- info->addRedirect(responses[i], crossOrigin);
- }
+ addRedirectsToTimingInfo(resource, info.get());
if (resource->response().isHTTP() &&
resource->response().httpStatusCode() < 400) {
@@ -1310,7 +1335,7 @@ bool ResourceFetcher::startLoad(Resource* resource) {
else
m_nonBlockingLoaders.add(loader);
- storeResourceTimingInitiatorInformation(resource);
+ storePerformanceTimingInitiatorInformation(resource);
resource->setFetcherSecurityOrigin(sourceOrigin);
loader->activateCacheAwareLoadingIfNeeded(request);
@@ -1400,6 +1425,14 @@ bool ResourceFetcher::willFollowRedirect(
bool crossOrigin = IsCrossOrigin(redirectResponse.url(), newRequest.url());
it->value->addRedirect(redirectResponse, crossOrigin);
}
+
+ if (resource->getType() == Resource::MainResource &&
+ resource->identifier() == m_mainResourceIdentifier) {
+ DCHECK(m_mainResourceTimingInfo);
+ bool crossOrigin = IsCrossOrigin(redirectResponse.url(), newRequest.url());
+ m_mainResourceTimingInfo->addRedirect(redirectResponse, crossOrigin);
+ }
+
newRequest.setAllowStoredCredentials(resource->options().allowCredentials ==
AllowStoredCredentials);
willSendRequest(resource->identifier(), newRequest, redirectResponse,

Powered by Google App Engine
This is Rietveld 408576698