transferSize implementation

third_party/WebKit/Source/core/timing/PerformanceBase.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 318 matching lines @@
   if (!isResourceTimingBufferFull())
     addResourceTimingBuffer(*entry);
 }
 
 void PerformanceBase::addNavigationTiming(LocalFrame* frame) {
   if (!RuntimeEnabledFeatures::performanceNavigationTiming2Enabled())
     return;
   DCHECK(frame);
   const DocumentLoader* documentLoader = frame->loader().documentLoader();
   DCHECK(documentLoader);
+
   const DocumentLoadTiming& documentLoadTiming = documentLoader->timing();
 
   const DocumentTiming* documentTiming =
       frame->document() ? &(frame->document()->timing()) : nullptr;
 
   const ResourceResponse& finalResponse = documentLoader->response();
+  ResourceTimingInfo* resourceTimingInfo =
+      documentLoader->getMainResourceTimingInfo();

[Nate Chapin, 2016/12/06 20:07:50]

Should the main resource timing info always be the first entry in the
m_resourceTimingBuffer? Could we get away without this accessor?

[sunjian, 2016/12/07 19:09:50]

We need this accessor to access non-iframe main resource, which wasn't captured
before because this is specifically for navigation timing 2. The first entry in
m_resourceTimingBuffer you referred is iframe. I'll change the name of the
method and buffer just to be more clear.

+  // Don't create navigation timing instance when resourceTimingInfo
+  // is null, which could happen when it is an iframe navigation restored
+  // from history, since its location may have been changed after initial
+  // navigation.
+  if (!resourceTimingInfo)
+    return;
 
   ResourceLoadTiming* resourceLoadTiming = finalResponse.resourceLoadTiming();
   // Don't create a navigation timing instance when
   // resourceLoadTiming is null, which could happen when visiting non-http sites
   // such as about:blank or in some error cases.
   if (!resourceLoadTiming)
     return;
   double lastRedirectEndTime = documentLoadTiming.redirectEnd();
   double finishTime = documentLoadTiming.loadEventEnd();
 
-  // TODO(sunjian) Implement transfer size. crbug/663187
-  unsigned long long transferSize = 0;
+  unsigned long long transferSize = resourceTimingInfo->transferSize();
   unsigned long long encodedBodyLength = finalResponse.encodedBodyLength();
   unsigned long long decodedBodyLength = finalResponse.decodedBodyLength();
   bool didReuseConnection = finalResponse.connectionReused();
   PerformanceNavigationTiming::NavigationType type =
       getNavigationType(documentLoader->getNavigationType(), frame->document());
 
   m_navigationTiming = new PerformanceNavigationTiming(
       timeOrigin(), documentLoadTiming.unloadEventStart(),
       documentLoadTiming.unloadEventEnd(), documentLoadTiming.loadEventStart(),
       documentLoadTiming.loadEventEnd(), documentLoadTiming.redirectCount(),
@@ skipping 187 matching lines @@
   visitor->trace(m_resourceTimingBuffer);
   visitor->trace(m_navigationTiming);
   visitor->trace(m_userTiming);
   visitor->trace(m_observers);
   visitor->trace(m_activeObservers);
   visitor->trace(m_suspendedObservers);
   EventTargetWithInlineData::trace(visitor);
 }
 
 }  // namespace blink