Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2511303002: [Downloads] Add support for tracking incomplete downloads (Closed)

Created:
4 years, 1 month ago by gone
Modified:
4 years, 1 month ago
Reviewers:
Theresa, qinmin
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Add support for tracking incomplete downloads * Start tracking most DownloadItems on the Java side, but display only completed downloads in the UI. * Start monitoring for the creation of DownloadItems, which happens when new downloads are triggered. * Change how deletion is done and undone: Instead of straight up removing items from the adapter, hide the DownloadItems from view until we are alerted that the downloads have been deleted by the backends. This allows us to keep track and simplifies a few data structure interactions. * Add proper support for monitoring changes to DownloadItems, and add functions for checking if updates should be communicated to the UI. BUG=658246, 654630 Committed: https://crrev.com/13fa9f45a129fb1404d39b11e30fa911dbc534f8 Cr-Commit-Position: refs/heads/master@{#433287}

Patch Set 1 #

Patch Set 2 : Remove unnecessary function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -161 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/BackendItems.java View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java View 1 8 chunks +61 lines, -51 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java View 13 chunks +90 lines, -38 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilePathsToDownloadItemsMap.java View 2 chunks +1 line, -18 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java View 5 chunks +37 lines, -20 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java View 10 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/android/download/download_manager_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/download/download_manager_service.cc View 4 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
gone
Min for changes to DownloadManagerService Theresa for all the other things and stuff
4 years, 1 month ago (2016-11-17 23:56:36 UTC) #2
qinmin
DownloadManagerService lgtm
4 years, 1 month ago (2016-11-18 19:06:12 UTC) #5
Theresa
lgtm
4 years, 1 month ago (2016-11-18 19:25:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511303002/20001
4 years, 1 month ago (2016-11-18 19:28:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 20:22:36 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 20:26:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13fa9f45a129fb1404d39b11e30fa911dbc534f8
Cr-Commit-Position: refs/heads/master@{#433287}

Powered by Google App Engine
This is Rietveld 408576698