Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2511283002: Revert of scheduler: Re-enable timer throttling for hidden frames (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years, 1 month ago
Reviewers:
kinuko, Z_DONOTUSE, ojan
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of scheduler: Re-enable timer throttling for hidden frames (patchset #6 id:100001 of https://codereview.chromium.org/2468863002/ ) Reason for revert: Regressed crbug.com/647393. Original issue's description: > scheduler: Re-enable timer throttling for hidden frames > > Turn hidden timer throttling back now that the issue with Gmail pop-ups > not working has been resolved by https://codereview.chromium.org/2272773002/. > > This patch also fixes a timer throttling related rebase error in a > previous patch and adds new layout test that cover out-of-view timer > and requestAnimationFrame throttling. > > Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_Lhz8THHk2Q > > BUG=616519, 647393 > > Committed: https://crrev.com/1688130897aed95d32e3904a6aa10384414fbefe > Cr-Commit-Position: refs/heads/master@{#432642} TBR=kinuko@chromium.org,ojan@chromium.org,ojan@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=616519, 647393 Committed: https://crrev.com/32461cca06891c91b22bb827c240333035d37289 Cr-Commit-Position: refs/heads/master@{#433061}

Patch Set 1 #

Messages

Total messages: 14 (6 generated)
Sami
Created Revert of scheduler: Re-enable timer throttling for hidden frames
4 years, 1 month ago (2016-11-17 23:04:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511283002/1
4 years, 1 month ago (2016-11-17 23:06:44 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/334464)
4 years, 1 month ago (2016-11-18 00:27:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511283002/1
4 years, 1 month ago (2016-11-18 00:34:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-18 01:10:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511283002/1
4 years, 1 month ago (2016-11-18 01:49:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 03:27:53 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 03:32:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32461cca06891c91b22bb827c240333035d37289
Cr-Commit-Position: refs/heads/master@{#433061}

Powered by Google App Engine
This is Rietveld 408576698