content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc - Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource. (Closed)

Patch Set: Another attempt to fix the crash Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/gpu_process_transport_factory.cc ('K') | « content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h ('k') | content/browser/compositor/mus_browser_compositor_output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

index 2cec7abf66ad0430130b3ee0401d210798e39966..174c6ebf4524abcfaa5aa0a309514420c8cdb4af 100644

--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

@@ -23,7 +23,6 @@ GpuSurfacelessBrowserCompositorOutputSurface::

scoped_refptr<ContextProviderCommandBuffer> context,

gpu::SurfaceHandle surface_handle,

scoped_refptr<ui::CompositorVSyncManager> vsync_manager,

- cc::SyntheticBeginFrameSource* begin_frame_source,

std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator>

overlay_candidate_validator,

unsigned int target,

@@ -32,7 +31,6 @@ GpuSurfacelessBrowserCompositorOutputSurface::

gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager)

: GpuBrowserCompositorOutputSurface(std::move(context),

std::move(vsync_manager),

- begin_frame_source,

std::move(overlay_candidate_validator)),

gpu_memory_buffer_manager_(gpu_memory_buffer_manager) {

capabilities_.uses_default_gl_framebuffer = false;