Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface.cc

Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource. (Closed)
Patch Set: Bring back GpuBrowserCompositorOutputSurface destructor Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/compositor/software_browser_compositor_output_surface.cc
diff --git a/content/browser/compositor/software_browser_compositor_output_surface.cc b/content/browser/compositor/software_browser_compositor_output_surface.cc
index 4e6fd5f83a548d2b678b64c6310fd7e89be60462..91488f687f4d6cfd71803a81951ca1b8b596110f 100644
--- a/content/browser/compositor/software_browser_compositor_output_surface.cc
+++ b/content/browser/compositor/software_browser_compositor_output_surface.cc
@@ -23,12 +23,10 @@ namespace content {
SoftwareBrowserCompositorOutputSurface::SoftwareBrowserCompositorOutputSurface(
std::unique_ptr<cc::SoftwareOutputDevice> software_device,
- const scoped_refptr<ui::CompositorVSyncManager>& vsync_manager,
- cc::SyntheticBeginFrameSource* begin_frame_source,
+ const UpdateVSyncParametersCallback& update_vsync_parameters_callback,
scoped_refptr<base::SingleThreadTaskRunner> task_runner)
: BrowserCompositorOutputSurface(std::move(software_device),
- vsync_manager,
- begin_frame_source),
+ update_vsync_parameters_callback),
task_runner_(std::move(task_runner)),
weak_factory_(this) {}
@@ -80,11 +78,8 @@ void SoftwareBrowserCompositorOutputSurface::SwapBuffers(
frame.latency_info));
gfx::VSyncProvider* vsync_provider = software_device()->GetVSyncProvider();
- if (vsync_provider) {
- vsync_provider->GetVSyncParameters(base::Bind(
- &BrowserCompositorOutputSurface::OnUpdateVSyncParametersFromGpu,
- weak_factory_.GetWeakPtr()));
- }
+ if (vsync_provider)
+ vsync_provider->GetVSyncParameters(update_vsync_parameters_callback_);
task_runner_->PostTask(
FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698