content/browser/compositor/vulkan_browser_compositor_output_surface.cc - Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/vulkan_browser_compositor_output_surface.cc

Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource. (Closed)

Patch Set: Addressed CR feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/software_browser_compositor_output_surface.cc ('K') | « content/browser/compositor/vulkan_browser_compositor_output_surface.h ('k') | ui/compositor/compositor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/vulkan_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/vulkan_browser_compositor_output_surface.cc b/content/browser/compositor/vulkan_browser_compositor_output_surface.cc

index da97d27459160e3b82ac538da777df23ccde225f..5cd2930ab0c0ee43ef4b5fca8235629bc80265fd 100644

--- a/content/browser/compositor/vulkan_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/vulkan_browser_compositor_output_surface.cc

@@ -12,10 +12,10 @@ namespace content {

VulkanBrowserCompositorOutputSurface::VulkanBrowserCompositorOutputSurface(

scoped_refptr<cc::VulkanContextProvider> context,

- scoped_refptr<ui::CompositorVSyncManager> vsync_manager,

+ const UpdateVSyncParametersCallback& update_vsync_parameters_callback,

cc::SyntheticBeginFrameSource* begin_frame_source)

: BrowserCompositorOutputSurface(std::move(context),

- std::move(vsync_manager),

+ update_vsync_parameters_callback,

begin_frame_source),

weak_ptr_factory_(this) {}