content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h - Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource. (Closed)

Patch Set: Addressed CR feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/gpu_browser_compositor_output_surface.cc ('K') | « content/browser/compositor/gpu_process_transport_factory.cc ('k') | content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc » ('j') | content/browser/compositor/software_browser_compositor_output_surface.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

index 87581ff34387d7a9a6dda8b68c307ab4b540d9f7..1f84987a79ece3a2f9ad2d2f5b1a1141ee83da2b 100644

--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

@@ -27,8 +27,7 @@ class GpuSurfacelessBrowserCompositorOutputSurface

GpuSurfacelessBrowserCompositorOutputSurface(

scoped_refptr<ContextProviderCommandBuffer> context,

gpu::SurfaceHandle surface_handle,

- scoped_refptr<ui::CompositorVSyncManager> vsync_manager,

- cc::SyntheticBeginFrameSource* begin_frame_source,

+ const UpdateVSyncParametersCallback& update_vsync_parameters_callback,

std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator>

overlay_candidate_validator,

unsigned int target,