Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: chrome/common/render_messages.h

Issue 2511263003: [HBD] Fix the misleading no-fallback placeholder message in BLOCK mode. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Multiply-included file, no traditional include guard. 5 // Multiply-included file, no traditional include guard.
6 #include <stdint.h> 6 #include <stdint.h>
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 19 matching lines...) Expand all
30 #include "ui/base/window_open_disposition.h" 30 #include "ui/base/window_open_disposition.h"
31 #include "url/gurl.h" 31 #include "url/gurl.h"
32 #include "url/ipc/url_param_traits.h" 32 #include "url/ipc/url_param_traits.h"
33 #include "url/origin.h" 33 #include "url/origin.h"
34 34
35 // Singly-included section for enums and custom IPC traits. 35 // Singly-included section for enums and custom IPC traits.
36 #ifndef CHROME_COMMON_RENDER_MESSAGES_H_ 36 #ifndef CHROME_COMMON_RENDER_MESSAGES_H_
37 #define CHROME_COMMON_RENDER_MESSAGES_H_ 37 #define CHROME_COMMON_RENDER_MESSAGES_H_
38 38
39 // These are only used internally, so the order does not matter. 39 // These are only used internally, so the order does not matter.
40 enum class ChromeViewHostMsg_GetPluginInfo_Status { 40 enum class ChromeViewHostMsg_GetPluginInfo_Status {
Nico 2016/11/24 00:40:37 it'd be nice if these had comments about what they
tommycli 2016/11/28 20:21:26 Done. I added some comments on the less obvious on
41 kAllowed, 41 kAllowed,
42 kBlocked, 42 kBlocked,
43 kBlockedByPolicy, 43 kBlockedByPolicy,
44 kBlockedNoLoading,
44 kComponentUpdateRequired, 45 kComponentUpdateRequired,
45 kDisabled, 46 kDisabled,
46 kFlashHiddenPreferHtml, 47 kFlashHiddenPreferHtml,
47 kNotFound, 48 kNotFound,
48 kOutdatedBlocked, 49 kOutdatedBlocked,
49 kOutdatedDisallowed, 50 kOutdatedDisallowed,
50 kPlayImportantContent, 51 kPlayImportantContent,
51 kRestartRequired, 52 kRestartRequired,
52 kUnauthorized, 53 kUnauthorized,
53 }; 54 };
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
594 595
595 #if defined(ENABLE_PLUGINS) 596 #if defined(ENABLE_PLUGINS)
596 // Sent by the renderer to check if crash reporting is enabled. 597 // Sent by the renderer to check if crash reporting is enabled.
597 IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled, 598 IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,
598 bool /* enabled */) 599 bool /* enabled */)
599 #endif 600 #endif
600 601
601 // Sent by the renderer to indicate that a fields trial has been activated. 602 // Sent by the renderer to indicate that a fields trial has been activated.
602 IPC_MESSAGE_CONTROL1(ChromeViewHostMsg_FieldTrialActivated, 603 IPC_MESSAGE_CONTROL1(ChromeViewHostMsg_FieldTrialActivated,
603 std::string /* name */) 604 std::string /* name */)
OLDNEW
« no previous file with comments | « chrome/browser/plugins/plugin_info_message_filter.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698