arc: bluetooth: enable use_new_wrapper_types for bluetooth.mojom

arc: bluetooth: enable use_new_wrapper_types for bluetooth.mojom

BUG=665978
BUG=624136
TEST=trybot, minnie worked fine

Committed: https://crrev.com/34878653192827ef94e0c34bd94e5be554825822
Cr-Commit-Position: refs/heads/master@{#433293}

[puthik_chromium, 2016-11-17 21:22:00]

The CQ bit was checked by puthik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 21:23:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[puthik_chromium, 2016-11-17 21:27:53]

puthik@chromium.org changed reviewers:
+ lhchavez@chromium.org, rickyz@chromium.org

[puthik_chromium, 2016-11-17 21:27:53]

PTAL
Owner: lhchavez, rickyz
fyi: yusukes, steel, mcchou

[puthik_chromium, 2016-11-17 21:29:16]

The CQ bit was unchecked by puthik@chromium.org

[puthik_chromium, 2016-11-17 21:34:58]

The CQ bit was checked by puthik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 21:36:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-11-17 22:45:19]

thanks a bunch for doing this :D

lgtm with nits.

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/bluetooth_struct_traits_unittest.cc (right):

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/bluetooth_struct_traits_unittest.cc:145:
data->set_manufacturer_data((std::vector<uint8_t>()));
you should be able to remove one set of parens. I don't think this is one of
those "most vexing parse" things (and if it is, use braces to disambiguate).

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/bluetooth_type_converters.cc (right):

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/bluetooth_type_converters.cc:60: mojo_addr->address =
address_bytes;
nit: does

base::HexStringToBytes(stripped, &mojo_addr->address);

work?

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/bluetooth_type_converters_unittest.cc (right):

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/bluetooth_type_converters_unittest.cc:307:
sequenceNoData->sequence =
All these places where you're initializing to an empty vendor are not needed,
since the (new) generated code does empty-initialize it for you.

[puthik_chromium, 2016-11-17 23:09:46]

The CQ bit was checked by puthik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 23:10:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[puthik_chromium, 2016-11-17 23:12:29]

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/bluetooth_struct_traits_unittest.cc (right):

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/bluetooth_struct_traits_unittest.cc:145:
data->set_manufacturer_data((std::vector<uint8_t>()));
On 2016/11/17 22:45:19, Luis Héctor Chávez wrote:
> you should be able to remove one set of parens. I don't think this is one of
> those "most vexing parse" things (and if it is, use braces to disambiguate).

Done. Didn't saw that there was 2 set of parens.

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/bluetooth_type_converters.cc (right):

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/bluetooth_type_converters.cc:60: mojo_addr->address =
address_bytes;
On 2016/11/17 22:45:19, Luis Héctor Chávez wrote:
> nit: does
> 
> base::HexStringToBytes(stripped, &mojo_addr->address);
> 
> work?

Done. stripped also not need.

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/bluetooth_type_converters_unittest.cc (right):

https://codereview.chromium.org/2511253002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/bluetooth_type_converters_unittest.cc:307:
sequenceNoData->sequence =
On 2016/11/17 22:45:19, Luis Héctor Chávez wrote:
> All these places where you're initializing to an empty vendor are not needed,
> since the (new) generated code does empty-initialize it for you.

Done.

[rickyz (no longer on Chrome), 2016-11-17 23:55:25]

Thanks from me as well for the cleanup!

[rickyz (no longer on Chrome), 2016-11-17 23:55:36]

Oops, forgot to include lgtm

[commit-bot: I haz the power, 2016-11-18 01:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 01:14:18]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[puthik_chromium, 2016-11-18 01:23:03]

The CQ bit was checked by puthik@chromium.org

[puthik_chromium, 2016-11-18 01:23:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2511253002/#ps40001
(title: "Fix lhchavez nit")

[commit-bot: I haz the power, 2016-11-18 01:25:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 04:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 04:20:30]

Failed to apply patch for components/arc/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: components/arc/BUILD.gn:128
  error: components/arc/BUILD.gn: patch does not apply

Patch:       components/arc/BUILD.gn
Index: components/arc/BUILD.gn
diff --git a/components/arc/BUILD.gn b/components/arc/BUILD.gn
index
8d7adaed7c541750405743d28edaf4d836cf05cf..0deb70ba22c53a805b89b00c0df118b8e9460c8b
100644
--- a/components/arc/BUILD.gn
+++ b/components/arc/BUILD.gn
@@ -128,7 +128,6 @@ static_library("arc_base") {
 mojom("arc_bindings_old_types") {
   sources = [
     "common/bitmap.mojom",
-    "common/bluetooth.mojom",
     "common/net.mojom",
     "common/video_accelerator.mojom",
   ]
@@ -147,6 +146,7 @@ mojom("arc_bindings") {
     "common/arc_bridge.mojom",
     "common/audio.mojom",
     "common/auth.mojom",
+    "common/bluetooth.mojom",
     "common/boot_phase_monitor.mojom",
     "common/clipboard.mojom",
     "common/crash_collector.mojom",

[puthik_chromium, 2016-11-18 18:59:09]

The CQ bit was checked by puthik@chromium.org

[puthik_chromium, 2016-11-18 18:59:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, rickyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2511253002/#ps60001
(title: "Rebase again")

[commit-bot: I haz the power, 2016-11-18 18:59:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 20:58:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-18 21:02:22]

Description was changed from

==========
arc: bluetooth: enable use_new_wrapper_types for bluetooth.mojom

BUG=665978
BUG=624136
TEST=trybot, minnie worked fine
==========

to

==========
arc: bluetooth: enable use_new_wrapper_types for bluetooth.mojom

BUG=665978
BUG=624136
TEST=trybot, minnie worked fine

Committed: https://crrev.com/34878653192827ef94e0c34bd94e5be554825822
Cr-Commit-Position: refs/heads/master@{#433293}
==========

[commit-bot: I haz the power, 2016-11-18 21:02:23]

Patchset 4 (id:??) landed as
https://crrev.com/34878653192827ef94e0c34bd94e5be554825822
Cr-Commit-Position: refs/heads/master@{#433293}