Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2511243004: Revert of [interpreter] Properly collect rhs feedback for comparisons with oddballs. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Properly collect rhs feedback for comparisons with oddballs. (patchset #1 id:1 of https://codereview.chromium.org/2513903002/ ) Reason for revert: Seems to break layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11452 Original issue's description: > [interpreter] Properly collect rhs feedback for comparisons with oddballs. > > Ignition skipped collecting NumberOrOddball feedback if the right hand > side of a relational comparison is undefined, thus leading to a > deoptimization loop, because it reported Number feedback to TurboFan. > > This was caught on 3d-raytrace test of SunSpider. > > R=rmcilroy@chromium.org > > Committed: https://crrev.com/d240ffec32ae034e50c006f7d5715171b32bbbc4 > Cr-Commit-Position: refs/heads/master@{#41094} TBR=rmcilroy@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/572b643b478debd0dd811f15b1b13bb3a28c7c46 Cr-Commit-Position: refs/heads/master@{#41100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/interpreter/interpreter.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [interpreter] Properly collect rhs feedback for comparisons with oddballs.
4 years, 1 month ago (2016-11-18 12:00:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511243004/1
4 years, 1 month ago (2016-11-18 12:01:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 12:02:06 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 12:02:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/572b643b478debd0dd811f15b1b13bb3a28c7c46
Cr-Commit-Position: refs/heads/master@{#41100}

Powered by Google App Engine
This is Rietveld 408576698