Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2511213003: Revert of chromium_android: Add device affinity to links (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of chromium_android: Add device affinity to links (patchset #1 id:1 of https://codereview.chromium.org/2284913002/ ) Reason for revert: Ended up being harder to use than I thought. We use step text for now :/ Original issue's description: > chromium_android: Add device affinity to links > > This is so that sheriff-o-matic has a more structured way to get the > device affinity of a particular step. > > Recipe-Tryjob-Bypass-Reason: Downstream diffs expected > Committed: https://chromium.googlesource.com/chromium/tools/build/+/cff87e6a98e85207aba12e0f73cc7bf7e779b002 Committed: https://chromium.googlesource.com/chromium/tools/build/+/5197041e29af7d07fe72b71b41c198c44ac7424c

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Retrain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -444 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 1 chunk +1 line, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/enable_platform_mode_basic.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/last_known_devices_basic.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_low_battery_basic.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_disable_location_basic.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_user_build_basic.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_failure.json View 1 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_infra_failure.json View 1 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json View 1 2 8 chunks +8 lines, -24 lines 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder.json View 1 2 6 chunks +6 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/host_info_failure.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 1 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 1 2 chunks +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_builder.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json View 1 2 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
martiniss
Created Revert of chromium_android: Add device affinity to links
4 years, 1 month ago (2016-11-18 00:07:22 UTC) #1
martiniss
PTAL
4 years, 1 month ago (2016-11-18 00:07:58 UTC) #3
jbudorick
lgtm Sorry about the delay. I probably saw "Revert of..." and ignored this :(
4 years ago (2016-11-29 16:29:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511213003/1
4 years ago (2016-11-29 19:04:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/32ca4ebda810d610)
4 years ago (2016-11-29 19:10:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511213003/300001
4 years ago (2016-11-29 19:30:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/32ca62b9733da710)
4 years ago (2016-11-29 20:05:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511213003/320001
4 years ago (2016-11-29 21:35:09 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-29 21:44:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:320001) as
https://chromium.googlesource.com/chromium/tools/build/+/5197041e29af7d07fe72...

Powered by Google App Engine
This is Rietveld 408576698