Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: src/core/SkTypeface.cpp

Issue 25112002: Limit warning message to de-clutter bench output logs (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Also want to see warning in Release Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkTypeface.cpp
===================================================================
--- src/core/SkTypeface.cpp (revision 11507)
+++ src/core/SkTypeface.cpp (working copy)
@@ -253,7 +253,12 @@
int SkTypeface::onCharsToGlyphs(const void* chars, Encoding encoding,
uint16_t glyphs[], int glyphCount) const {
- SkDebugf("onCharsToGlyphs unimplemented\n");
+ static bool printed = false;
+ if (!printed) {
+ // Only want to see this message once
+ SkDebugf("\n *** onCharsToGlyphs unimplemented ***\n");
+ printed = true;
+ }
if (glyphs && glyphCount > 0) {
sk_bzero(glyphs, glyphCount * sizeof(glyphs[0]));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698