Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2511183002: Remove IFWL_ToolTipDP (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IFWL_ToolTipDP There are no longer any classes which implement this interface. Remove interface. Committed: https://pdfium.googlesource.com/pdfium/+/218a37894a58cd23eb764aec96ff21331b6e68cc

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M xfa/fwl/core/ifwl_tooltip.h View 2 chunks +0 lines, -12 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.cpp View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
dsinclair
PTAL. The CFWL_ToolTipContainer was the only implementation and it was removed as unused.
4 years, 1 month ago (2016-11-17 18:30:20 UTC) #2
npm
lgtm
4 years, 1 month ago (2016-11-17 18:36:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511183002/20001
4 years, 1 month ago (2016-11-17 21:38:26 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
4 years, 1 month ago (2016-11-17 22:04:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511183002/20001
4 years, 1 month ago (2016-11-17 22:07:12 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
4 years, 1 month ago (2016-11-17 22:07:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511183002/40001
4 years, 1 month ago (2016-11-17 22:09:03 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:42:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/218a37894a58cd23eb764aec96ff21331b6e...

Powered by Google App Engine
This is Rietveld 408576698