Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2511163002: harmony: convert collected cookies dialog (Closed)

Created:
4 years, 1 month ago by Elly Fong-Jones
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

harmony: convert collected cookies dialog The collected cookies dialog now uses Harmony layout constants and spacing when in Harmony mode. BUG=610428 Committed: https://crrev.com/bdb391bae9fd0c8f4ffdd706c1dabf510c291a4d Cr-Commit-Position: refs/heads/master@{#433879}

Patch Set 1 #

Patch Set 2 : add Harmony width #

Patch Set 3 : remove ?: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -21 lines) Patch
M chrome/browser/ui/views/collected_cookies_views.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 2 10 chunks +48 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/harmony/harmony_layout_delegate.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/harmony_layout_delegate.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/layout_delegate.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/layout_delegate.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Elly Fong-Jones
sky: ptal? This change introduces a couple of pixels of difference in the non-Harmony version ...
4 years, 1 month ago (2016-11-17 16:21:31 UTC) #3
sky
LGTM
4 years, 1 month ago (2016-11-17 18:49:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511163002/20001
4 years, 1 month ago (2016-11-17 19:46:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/298868)
4 years, 1 month ago (2016-11-17 20:26:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511163002/40001
4 years, 1 month ago (2016-11-22 15:32:52 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-22 16:17:57 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-22 16:19:59 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bdb391bae9fd0c8f4ffdd706c1dabf510c291a4d
Cr-Commit-Position: refs/heads/master@{#433879}

Powered by Google App Engine
This is Rietveld 408576698