Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: media/base/media_observer.h

Issue 2511143006: Detect change on the intersection of video and viewport. (Closed)
Patch Set: Addressed comments from PS#2. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_observer.h
diff --git a/media/base/media_observer.h b/media/base/media_observer.h
index c3e29a1789f173d2cc62ad12845392cfaf1a70f7..59d3bb118c022602af99633c72a7da82088ee1ea 100644
--- a/media/base/media_observer.h
+++ b/media/base/media_observer.h
@@ -20,6 +20,11 @@ class MEDIA_EXPORT MediaObserver {
virtual void OnEnteredFullscreen() = 0;
virtual void OnExitedFullscreen() = 0;
+ // Called when the media element starts/stops stably filling most of the
+ // viewport.
+ virtual void OnStablyFilledMostViewportChanged(
ojan 2016/11/24 00:48:33 Nit: These methods would be easier to understand i
xjz 2016/11/24 02:16:16 Done.
+ bool is_mostly_filling_viewport) {}
+
// Called when CDM is attached to the media element. The |cdm_context| is
// only guaranteed to be valid in this call.
virtual void OnSetCdm(CdmContext* cdm_context) = 0;
« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.h » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698