Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2511143003: ExtensionInstallUIDefault cleanup: Remove check for InstantExtended API (Closed)

Created:
4 years, 1 month ago by Marc Treib
Modified:
4 years, 1 month ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExtensionInstallUIDefault cleanup: Remove check for InstantExtended API InstantExtended has been enabled for years (on desktop), and anyway checking it here doesn't make any sense BUG=627747 Committed: https://crrev.com/bd0a0a87c71f81df59b8fdf0b6dcd70ff9e65b1a Cr-Commit-Position: refs/heads/master@{#433153}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 2 chunks +2 lines, -6 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
Marc Treib
Tiny cleanup - PTAL! https://codereview.chromium.org/2511143003/diff/1/chrome/browser/ui/extensions/extension_install_ui_default.cc File chrome/browser/ui/extensions/extension_install_ui_default.cc (left): https://codereview.chromium.org/2511143003/diff/1/chrome/browser/ui/extensions/extension_install_ui_default.cc#oldcode234 chrome/browser/ui/extensions/extension_install_ui_default.cc:234: : chrome::kChromeUINewTabURL); I suspect this ...
4 years, 1 month ago (2016-11-17 18:10:46 UTC) #4
Devlin
lgtm
4 years, 1 month ago (2016-11-18 01:55:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511143003/1
4 years, 1 month ago (2016-11-18 08:52:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 08:57:13 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 08:59:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd0a0a87c71f81df59b8fdf0b6dcd70ff9e65b1a
Cr-Commit-Position: refs/heads/master@{#433153}

Powered by Google App Engine
This is Rietveld 408576698