Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2511143002: Implement GenericURLRequestJob::GetLoadTimingInfo (Closed)

Created:
4 years, 1 month ago by alex clarke (OOO till 29th)
Modified:
4 years, 1 month ago
Reviewers:
Eric Seckler, altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement GenericURLRequestJob::GetLoadTimingInfo This is needed to safely load any resources with a header based redirect. BUG=546953 Committed: https://crrev.com/ec37e6478a8f312dda525c23037d360b05552711 Cr-Commit-Position: refs/heads/master@{#432888}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M headless/public/util/generic_url_request_job.h View 2 chunks +2 lines, -0 lines 0 comments Download
M headless/public/util/generic_url_request_job.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M headless/public/util/generic_url_request_job_test.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
alex clarke (OOO till 29th)
4 years, 1 month ago (2016-11-17 15:36:37 UTC) #2
altimin
https://codereview.chromium.org/2511143002/diff/1/headless/public/util/generic_url_request_job.cc File headless/public/util/generic_url_request_job.cc (right): https://codereview.chromium.org/2511143002/diff/1/headless/public/util/generic_url_request_job.cc#newcode192 headless/public/util/generic_url_request_job.cc:192: load_timing_info->receive_headers_end = response_time_; Should we also fill other fields ...
4 years, 1 month ago (2016-11-17 15:45:24 UTC) #3
altimin
4 years, 1 month ago (2016-11-17 15:52:42 UTC) #4
alex clarke (OOO till 29th)
PTAL https://codereview.chromium.org/2511143002/diff/1/headless/public/util/generic_url_request_job.cc File headless/public/util/generic_url_request_job.cc (right): https://codereview.chromium.org/2511143002/diff/1/headless/public/util/generic_url_request_job.cc#newcode192 headless/public/util/generic_url_request_job.cc:192: load_timing_info->receive_headers_end = response_time_; On 2016/11/17 15:45:24, altimin wrote: ...
4 years, 1 month ago (2016-11-17 16:05:59 UTC) #5
altimin
lgtm % nit https://codereview.chromium.org/2511143002/diff/1/headless/public/util/generic_url_request_job.cc File headless/public/util/generic_url_request_job.cc (right): https://codereview.chromium.org/2511143002/diff/1/headless/public/util/generic_url_request_job.cc#newcode192 headless/public/util/generic_url_request_job.cc:192: load_timing_info->receive_headers_end = response_time_; On 2016/11/17 16:05:59, ...
4 years, 1 month ago (2016-11-17 16:08:39 UTC) #6
alex clarke (OOO till 29th)
On 2016/11/17 16:05:59, alex clarke wrote: > PTAL > > https://codereview.chromium.org/2511143002/diff/1/headless/public/util/generic_url_request_job.cc > File headless/public/util/generic_url_request_job.cc (right): ...
4 years, 1 month ago (2016-11-17 16:09:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511143002/20001
4 years, 1 month ago (2016-11-17 16:10:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 16:21:07 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 16:23:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec37e6478a8f312dda525c23037d360b05552711
Cr-Commit-Position: refs/heads/master@{#432888}

Powered by Google App Engine
This is Rietveld 408576698