Revert of Handle push resubscribes with no sender info (avoids DCHECK)

Revert of Handle push resubscribes with no sender info (avoids DCHECK) (patchset #2 id:20001 of https://codereview.chromium.org/2487233002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20ChromeOS%20Buildspec%20Tests/builds/1007

Original issue's description:
> Handle push resubscribes with no sender info (avoids DCHECK)
> 
> - Prior to this patch you would fail a DCHECK if you called
>   PushManager.subscribe() with a sender id or key and then
>   PushManager.subscribe() without a sender id or key.
> 
> - This fixes that and only allows resubscribing with no sender info
> when the original subscribe was made with a gcm_sender_id.
> Otherwise we throw an AbortError - no key provided.
> 
> BUG=659230
> 
> Review-Url: https://codereview.chromium.org/2469293002
> Cr-Commit-Position: refs/heads/master@{#430601}
> (cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)
> 
> Committed: https://chromium.googlesource.com/chromium/src/+/bd071b0aaa4d50bb0cd48becbd108fa87802c728

TBR=harkness@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659230
NOTRY=true
NOPRESUBMIT=true
TBR=harkness@chromium.org

[jennyz, 2016-11-18 00:09:13]

The CQ bit was checked by jennyz@chromium.org

[jennyz, 2016-11-18 00:09:13]

Created Revert of Handle push resubscribes with no sender info (avoids DCHECK)

[commit-bot: I haz the power, 2016-11-18 00:10:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 00:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:10:45]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[jennyz, 2016-11-18 00:13:20]

Description was changed from

==========
Revert of Handle push resubscribes with no sender info (avoids DCHECK) (patchset
#2 id:20001 of https://codereview.chromium.org/2487233002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20Chrom...

Original issue's description:
> Handle push resubscribes with no sender info (avoids DCHECK)
> 
> - Prior to this patch you would fail a DCHECK if you called
>   PushManager.subscribe() with a sender id or key and then
>   PushManager.subscribe() without a sender id or key.
> 
> - This fixes that and only allows resubscribing with no sender info
> when the original subscribe was made with a gcm_sender_id.
> Otherwise we throw an AbortError - no key provided.
> 
> BUG=659230
> 
> Review-Url: https://codereview.chromium.org/2469293002
> Cr-Commit-Position: refs/heads/master@{#430601}
> (cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/bd071b0aaa4d50bb0cd48becbd10...

TBR=harkness@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659230
==========

to

==========
Revert of Handle push resubscribes with no sender info (avoids DCHECK) (patchset
#2 id:20001 of https://codereview.chromium.org/2487233002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20Chrom...

Original issue's description:
> Handle push resubscribes with no sender info (avoids DCHECK)
> 
> - Prior to this patch you would fail a DCHECK if you called
>   PushManager.subscribe() with a sender id or key and then
>   PushManager.subscribe() without a sender id or key.
> 
> - This fixes that and only allows resubscribing with no sender info
> when the original subscribe was made with a gcm_sender_id.
> Otherwise we throw an AbortError - no key provided.
> 
> BUG=659230
> 
> Review-Url: https://codereview.chromium.org/2469293002
> Cr-Commit-Position: refs/heads/master@{#430601}
> (cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/bd071b0aaa4d50bb0cd48becbd10...

TBR=harkness@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659230
NOTRY=true
NOPRESUBMIT=true
==========

[jennyz, 2016-11-18 00:13:24]

The CQ bit was checked by jennyz@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:14:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 00:18:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:19:04]

Failed to apply the patch.

[jennyz, 2016-11-18 07:20:01]

Description was changed from

==========
Revert of Handle push resubscribes with no sender info (avoids DCHECK) (patchset
#2 id:20001 of https://codereview.chromium.org/2487233002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20Chrom...

Original issue's description:
> Handle push resubscribes with no sender info (avoids DCHECK)
> 
> - Prior to this patch you would fail a DCHECK if you called
>   PushManager.subscribe() with a sender id or key and then
>   PushManager.subscribe() without a sender id or key.
> 
> - This fixes that and only allows resubscribing with no sender info
> when the original subscribe was made with a gcm_sender_id.
> Otherwise we throw an AbortError - no key provided.
> 
> BUG=659230
> 
> Review-Url: https://codereview.chromium.org/2469293002
> Cr-Commit-Position: refs/heads/master@{#430601}
> (cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/bd071b0aaa4d50bb0cd48becbd10...

TBR=harkness@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659230
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Revert of Handle push resubscribes with no sender info (avoids DCHECK) (patchset
#2 id:20001 of https://codereview.chromium.org/2487233002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20Chrom...

Original issue's description:
> Handle push resubscribes with no sender info (avoids DCHECK)
> 
> - Prior to this patch you would fail a DCHECK if you called
>   PushManager.subscribe() with a sender id or key and then
>   PushManager.subscribe() without a sender id or key.
> 
> - This fixes that and only allows resubscribing with no sender info
> when the original subscribe was made with a gcm_sender_id.
> Otherwise we throw an AbortError - no key provided.
> 
> BUG=659230
> 
> Review-Url: https://codereview.chromium.org/2469293002
> Cr-Commit-Position: refs/heads/master@{#430601}
> (cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/bd071b0aaa4d50bb0cd48becbd10...

TBR=harkness@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659230
NOTRY=true
NOPRESUBMIT=true
TBR=harkness@chromium.org
==========

[jennyz, 2016-11-18 07:20:01]

jennyz@chromium.org changed reviewers:
- harkness@chromium.org

[jennyz, 2016-11-18 07:20:14]

The CQ bit was checked by jennyz@chromium.org

[commit-bot: I haz the power, 2016-11-18 07:20:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 07:23:28]

Description was changed from

==========
Revert of Handle push resubscribes with no sender info (avoids DCHECK) (patchset
#2 id:20001 of https://codereview.chromium.org/2487233002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20Chrom...

Original issue's description:
> Handle push resubscribes with no sender info (avoids DCHECK)
> 
> - Prior to this patch you would fail a DCHECK if you called
>   PushManager.subscribe() with a sender id or key and then
>   PushManager.subscribe() without a sender id or key.
> 
> - This fixes that and only allows resubscribing with no sender info
> when the original subscribe was made with a gcm_sender_id.
> Otherwise we throw an AbortError - no key provided.
> 
> BUG=659230
> 
> Review-Url: https://codereview.chromium.org/2469293002
> Cr-Commit-Position: refs/heads/master@{#430601}
> (cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/bd071b0aaa4d50bb0cd48becbd10...

TBR=harkness@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659230
NOTRY=true
NOPRESUBMIT=true
TBR=harkness@chromium.org
==========

to

==========
Revert of Handle push resubscribes with no sender info (avoids DCHECK) (patchset
#2 id:20001 of https://codereview.chromium.org/2487233002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20Chrom...

Original issue's description:
> Handle push resubscribes with no sender info (avoids DCHECK)
> 
> - Prior to this patch you would fail a DCHECK if you called
>   PushManager.subscribe() with a sender id or key and then
>   PushManager.subscribe() without a sender id or key.
> 
> - This fixes that and only allows resubscribing with no sender info
> when the original subscribe was made with a gcm_sender_id.
> Otherwise we throw an AbortError - no key provided.
> 
> BUG=659230
> 
> Review-Url: https://codereview.chromium.org/2469293002
> Cr-Commit-Position: refs/heads/master@{#430601}
> (cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/bd071b0aaa4d50bb0cd48becbd10...

TBR=harkness@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659230
NOTRY=true
NOPRESUBMIT=true
TBR=harkness@chromium.org
==========

[commit-bot: I haz the power, 2016-11-18 07:23:29]

Committed patchset #1 (id:1)