Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2511133002: Fix for 'Remove iOS plist generation and ios_plist writer' (Closed)

Created:
4 years, 1 month ago by ljusten (tachyonic)
Modified:
4 years, 1 month ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for 'Remove iOS plist generation and ios_plist writer' Fix for https://codereview.chromium.org/2327023002/, have to remove chrome_policy.plist from policy_templates.gni. TBR=pastarmovj BUG=550407 Committed: https://crrev.com/8b0e589c9666655be36eb2628cddcb5fde665fb4 Cr-Commit-Position: refs/heads/master@{#432921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M components/policy/resources/policy_templates.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511133002/1
4 years, 1 month ago (2016-11-17 15:30:53 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-17 15:30:55 UTC) #4
pastarmovj
lgtm
4 years, 1 month ago (2016-11-17 15:56:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511133002/1
4 years, 1 month ago (2016-11-17 15:57:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/236966)
4 years, 1 month ago (2016-11-17 16:08:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511133002/1
4 years, 1 month ago (2016-11-17 16:43:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 18:35:54 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:28:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b0e589c9666655be36eb2628cddcb5fde665fb4
Cr-Commit-Position: refs/heads/master@{#432921}

Powered by Google App Engine
This is Rietveld 408576698