Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 251113005: Disable some webgl conformance tests due to a security issue on video canvas painting (Closed)

Created:
6 years, 7 months ago by qinmin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Disable some webgl conformance tests due to a security issue on video canvas painting Check http://crbug.com/334204 for details BUG=334204, 367962 R=alokp@chromium.org, kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266716

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
qinmin
PTAL
6 years, 7 months ago (2014-04-28 21:56:18 UTC) #1
alokp
This looks reasonable. Although if we are not sure about the patch, I would revert ...
6 years, 7 months ago (2014-04-28 22:36:54 UTC) #2
alokp
lgtm
6 years, 7 months ago (2014-04-28 22:47:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/251113005/20001
6 years, 7 months ago (2014-04-28 22:48:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:56:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 22:56:16 UTC) #6
Ken Russell (switch to Gerrit)
lgtm
6 years, 7 months ago (2014-04-28 23:01:49 UTC) #7
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 7 months ago (2014-04-28 23:33:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/251113005/20001
6 years, 7 months ago (2014-04-28 23:36:11 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:50:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 23:50:49 UTC) #11
alokp
6 years, 7 months ago (2014-04-29 00:21:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 manually as r266716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698