Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2511113002: [wasm] Introduce performance testing options. (Closed)

Created:
4 years, 1 month ago by titzer
Modified:
4 years, 1 month ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Introduce performance testing options. Adds --wasm-no-bounds-checks and --wasm-no-stack-checks which help in diagnosing potential sources of slowdown in WASM code. R=ahaas@chromium.org BUG= Committed: https://crrev.com/5e00cb5f08b4df926fde6c635dc1569cb1f7b526 Cr-Commit-Position: refs/heads/master@{#41083}

Patch Set 1 #

Patch Set 2 : [wasm] Introduce performance testing options --wasm-disable-bounds-checks and --wasm-disable-stack-… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/compiler/wasm-compiler.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
titzer
4 years, 1 month ago (2016-11-17 14:52:36 UTC) #1
ahaas
On 2016/11/17 at 14:52:36, titzer wrote: > nice, lgtm
4 years, 1 month ago (2016-11-17 14:54:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511113002/20001
4 years, 1 month ago (2016-11-17 15:15:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 16:01:48 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e00cb5f08b4df926fde6c635dc1569cb1f7b526
Cr-Commit-Position: refs/heads/master@{#41083}

Powered by Google App Engine
This is Rietveld 408576698